Bug 116733

Summary: -webView:didPerformClientRedirectFromURL:toURL:inFrame: should be given the redirecting URL as the “from” URL
Product: WebKit Reporter: mitz
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, mrowe, rniwa
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Track the last committed URL in WebFrame and pass it to the delegate in the client redirect case
adele: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 none

Description mitz 2013-05-24 12:16:07 PDT
<rdar://problem/13924889>

The first URL passed to -[NSObject(WebHistoryDelegate) webView:didPerformClientRedirectFromURL:toURL:inFrame:] is currently the URL at the beginning of the redirect chain. It should be the URL that performed the redirect.
Comment 1 mitz 2013-05-24 12:25:22 PDT
Created attachment 202845 [details]
Track the last committed URL in WebFrame and pass it to the delegate in the client redirect case
Comment 2 Build Bot 2013-05-24 14:15:44 PDT
Comment on attachment 202845 [details]
Track the last committed URL in WebFrame and pass it to the delegate in the client redirect case

Attachment 202845 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/725003

New failing tests:
svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
Comment 3 Build Bot 2013-05-24 14:15:45 PDT
Created attachment 202849 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 4 mitz 2013-05-24 14:18:37 PDT
The patch is strictly against WebKit1, so the test failures are almost certainly unrelated to it.
Comment 5 mitz 2013-05-25 10:57:12 PDT
Fixed in r150688.
<http://trac.webkit.org/r150688>