Bug 116724

Summary: [BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, anlo, commit-queue, rwlbuis, tabbott
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Carlos Garcia Campos 2013-05-24 08:56:44 PDT
It seems that the animations are triggered too often after r150071 in some cases.
Comment 1 Carlos Garcia Campos 2013-05-24 09:08:53 PDT
Created attachment 202828 [details]
Patch
Comment 2 Arvid Nilsson 2013-05-24 10:02:05 PDT
Comment on attachment 202828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202828&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:6343
> +    m_monotonicAnimationStartTime = monotonicallyIncreasingTime();

currentTime and monotonicallyIncreasingTime() ärr two incompatible time coordinate systems...

> Source/WebKit/blackberry/Api/WebPage.cpp:6382
> +    m_mainFrame->view()->serviceScriptedAnimations(monotonicAnimationStartTime);

...so which time coordinate system does serviceScriptedAnimations expect anyway? I noticed you used currentTime() in the previous patch...
Comment 3 Carlos Garcia Campos 2013-05-24 10:15:45 PDT
(In reply to comment #2)
> (From update of attachment 202828 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202828&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:6343
> > +    m_monotonicAnimationStartTime = monotonicallyIncreasingTime();
> 
> currentTime and monotonicallyIncreasingTime() ärr two incompatible time coordinate systems...

This is what display refresh monitor does, that's why I changed it.
Comment 4 Arvid Nilsson 2013-05-24 10:27:47 PDT
Alright, monotonic it is then! LGTM.
Comment 5 Rob Buis 2013-05-27 08:38:58 PDT
Comment on attachment 202828 [details]
Patch

Looks good.
Comment 6 WebKit Commit Bot 2013-05-27 08:50:59 PDT
Comment on attachment 202828 [details]
Patch

Clearing flags on attachment: 202828

Committed r150760: <http://trac.webkit.org/changeset/150760>
Comment 7 WebKit Commit Bot 2013-05-27 08:51:01 PDT
All reviewed patches have been landed.  Closing bug.