Bug 116724 – [BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

It seems that the animations are triggered too often after r150071 in some cases.

[Carlos Garcia Campos]

Created attachment 202828 [details]
Patch

[Arvid Nilsson]

Comment on attachment 202828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202828&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:6343
> +    m_monotonicAnimationStartTime = monotonicallyIncreasingTime();

currentTime and monotonicallyIncreasingTime() ärr two incompatible time coordinate systems...

> Source/WebKit/blackberry/Api/WebPage.cpp:6382
> +    m_mainFrame->view()->serviceScriptedAnimations(monotonicAnimationStartTime);

...so which time coordinate system does serviceScriptedAnimations expect anyway? I noticed you used currentTime() in the previous patch...

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 202828 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202828&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:6343
> > +    m_monotonicAnimationStartTime = monotonicallyIncreasingTime();
> 
> currentTime and monotonicallyIncreasingTime() ärr two incompatible time coordinate systems...

This is what display refresh monitor does, that's why I changed it.

[Arvid Nilsson]

Alright, monotonic it is then! LGTM.

[Rob Buis]

Comment on attachment 202828 [details]
Patch

Looks good.

[WebKit Commit Bot]

Comment on attachment 202828 [details]
Patch

Clearing flags on attachment: 202828

Committed r150760: <http://trac.webkit.org/changeset/150760>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.