Summary: | Improve loader/go-back-cached-main-resource.html test | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2013-05-24 01:13:48 PDT
Created attachment 202782 [details]
Patch
Comment on attachment 202782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202782&action=review Thank you! > LayoutTests/loader/resources/first-page.html:11 > + if (!event.persisted) { > + // Our opener will tell us to perform various loads. Just for the information, WebKit style is to prefer early returns, not deep indentation. I don't think that it's worth changing for this test, it's an extremely minor point. Comment on attachment 202782 [details] Patch Clearing flags on attachment: 202782 Committed r150645: <http://trac.webkit.org/changeset/150645> All reviewed patches have been landed. Closing bug. |