| Summary: | Inline TCMalloc_Central_FreeList's RemoveRange and FetchFromSpansSafe | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, cmarcelo, commit-queue, oliver, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Poulain
2013-05-23 20:56:03 PDT
Created attachment 202761 [details]
Patch
Comment on attachment 202761 [details]
Patch
do you have evidence that it's a win? ALWAYS_INLINE is a stick we use to beat the compiler on the head when it's making the wrong choice
Attachment 202761 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FastMalloc.cpp']" exit_code: 1
Source/WTF/wtf/FastMalloc.cpp:3054: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/WTF/wtf/FastMalloc.cpp:3092: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > (From update of attachment 202761 [details]) > do you have evidence that it's a win? ALWAYS_INLINE is a stick we use to beat the compiler on the head when it's making the wrong choice Yeah, I was surprised clang did not inline those already. Usually clang is really good at figuring out this kind of stuff. On the (very long) benchmark I ran, fastMalloc takes ~2%, and that was removing 1% of those 2%, so it helped very very little. You know this code quite well. Do you know of any opportunity to make fastMalloc faster on ARM? Comment on attachment 202761 [details] Patch Attachment 202761 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/720033 New failing tests: editing/undo/undo-after-setting-value.html Created attachment 202859 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Comment on attachment 202761 [details] Patch Clearing flags on attachment: 202761 Committed r150676: <http://trac.webkit.org/changeset/150676> All reviewed patches have been landed. Closing bug. |