Bug 116673

Summary: Make default bug links in buildbot clickable
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
rniwa: review+, rniwa: commit-queue-
Patch for landing none

Patrick R. Gansterer
Reported 2013-05-23 07:23:48 PDT
Make default bug links in buildbot clickable
Attachments
Patch (1.30 KB, patch)
2013-05-23 07:26 PDT, Patrick R. Gansterer 		rniwa: review+
rniwa: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (1.31 KB, patch)
2013-05-23 10:22 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-05-23 07:26:39 PDT
Created attachment 202709 [details] Patch
Ryosuke Niwa
Comment 2 2013-05-23 10:09:07 PDT
Comment on attachment 202709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202709&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:47 > + changecommentlink=(r"https://bugs\.webkit\.org/show_bug\.cgi\?id=(\d+)", "https://bugs.webkit.org/show_bug.cgi?id=\1"), We should probably also support the short form: webkit\.org/b/(\d+)
Patrick R. Gansterer
Comment 3 2013-05-23 10:12:06 PDT
(In reply to comment #2) > (From update of attachment 202709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202709&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:47 > > + changecommentlink=(r"https://bugs\.webkit\.org/show_bug\.cgi\?id=(\d+)", "https://bugs.webkit.org/show_bug.cgi?id=\1"), > > We should probably also support the short form: webkit\.org/b/(\d+) But then is the question if we want to support _all_ http[s]:// links in the commit message? Adding more than one link would require that we change the whole commit message by adding the anker tags ourself... It's doable, but I think that this should be ok when people use webkit-patch for creating patches....
Ryosuke Niwa
Comment 4 2013-05-23 10:14:30 PDT
Comment on attachment 202709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202709&action=review >>> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:47 >>> + changecommentlink=(r"https://bugs\.webkit\.org/show_bug\.cgi\?id=(\d+)", "https://bugs.webkit.org/show_bug.cgi?id=\1"), >> >> We should probably also support the short form: webkit\.org/b/(\d+) > > But then is the question if we want to support _all_ http[s]:// links in the commit message? Adding more than one link would require that we change the whole commit message by adding the anker tags ourself... > It's doable, but I think that this should be ok when people use webkit-patch for creating patches.... Just do r"(https://bugs\.webkit\.org/show_bug\.cgi\?id=|webkit\.org/b/)(\d+)" and change \1 to \2.
Patrick R. Gansterer
Comment 5 2013-05-23 10:22:51 PDT
Created attachment 202725 [details] Patch for landing
WebKit Commit Bot
Comment 6 2013-05-23 10:49:23 PDT
Comment on attachment 202725 [details] Patch for landing Clearing flags on attachment: 202725 Committed r150592: <http://trac.webkit.org/changeset/150592>
WebKit Commit Bot
Comment 7 2013-05-23 10:49:25 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 8 2013-06-04 07:07:56 PDT
FYI, this patch did not work as intended it seems. Link are clickable but they all point to https://bugs.webkit.org/show_bug.cgi?id= (missing bug ID).
Ryosuke Niwa
Comment 9 2013-06-04 14:40:02 PDT
Fixed in http://trac.webkit.org/changeset/151185.
Note You need to log in before you can comment on or make changes to this bug.