Bug 11665

Summary: [S60] Text decoder regression in S60 browser
Product: WebKit Reporter: Wei Liu <wei.liu>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: S60webkit
Priority: P2    
Version: 420+   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
initialize the iQTextDecoder to null.
yongjun.zhang: review+
3.2 main branch changes
yongjun.zhang: review+
3.1 additional fixes, such as using makeDecoder in fromUnicode, etc. yongjun.zhang: review+

Wei Liu
Reported 2006-11-21 07:39:34 PST
A new member iQTextDecoder was introduced in QTextCodec class, however, it's not properly initialized (nulled). Since QTextCodec does not derive from CBase, its members will not be automatically nulled. This problem may cause potential crashes on websites which javascript needs char converted.
Attachments
initialize the iQTextDecoder to null. (1.31 KB, patch)
2006-11-21 08:03 PST, Wei Liu 		yongjun.zhang: review+
DetailsFormatted DiffDiff
3.2 main branch changes (3.82 KB, patch)
2006-11-22 11:52 PST, Wei Liu 		yongjun.zhang: review+
DetailsFormatted DiffDiff
3.1 additional fixes, such as using makeDecoder in fromUnicode, etc. (3.32 KB, patch)
2006-11-22 11:54 PST, Wei Liu 		yongjun.zhang: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wei Liu
Comment 1 2006-11-21 07:42:04 PST
The TSW error ID for this bug is WLIU-6VQSPD. This regression is caused by fix for bug 11486.
Wei Liu
Comment 2 2006-11-21 08:03:42 PST
Created attachment 11596 [details] initialize the iQTextDecoder to null.
Yongjun Zhang
Comment 3 2006-11-21 08:08:10 PST
Comment on attachment 11596 [details] initialize the iQTextDecoder to null. r=me
Bradley Morrison
Comment 4 2006-11-21 08:32:49 PST
please create s60webkit bugs with the correct attributes - we share this database with a lot of people not working on s60webkit! See the bus submission template linked from: http://trac.webkit.org/projects/webkit/wiki/S60Buzilla
alan
Comment 5 2006-11-22 07:59:31 PST
r17875
Wei Liu
Comment 6 2006-11-22 11:52:33 PST
Created attachment 11611 [details] 3.2 main branch changes
Wei Liu
Comment 7 2006-11-22 11:54:17 PST
Created attachment 11612 [details] 3.1 additional fixes, such as using makeDecoder in fromUnicode, etc.
Yongjun Zhang
Comment 8 2006-11-22 12:09:45 PST
Comment on attachment 11611 [details] 3.2 main branch changes r=me
Yongjun Zhang
Comment 9 2006-11-22 12:10:07 PST
Comment on attachment 11612 [details] 3.1 additional fixes, such as using makeDecoder in fromUnicode, etc. r=me
alan
Comment 10 2006-11-26 13:07:55 PST
3.2 -> r17881 3.1m -> r17882
Krishna
Comment 11 2006-11-30 13:53:46 PST
Verified and Closed.
Joel Parks
Comment 12 2011-03-21 11:52:50 PDT
re-purposing InTSW keyword for use by QtWebkit team
Note You need to log in before you can comment on or make changes to this bug.