Bug 116647

Summary: Clean the global crash hook handling
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: NEW    
Severity: Normal CC: buildbot, cmarcelo, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
bfulgham: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 none

Benjamin Poulain
Reported 2013-05-22 20:06:15 PDT
Clean the global crash hook handling
Attachments
Patch (5.94 KB, patch)
2013-05-22 20:11 PDT, Benjamin Poulain 		bfulgham: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (939.78 KB, application/zip)
2013-05-24 07:27 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-05-22 20:11:14 PDT
Created attachment 202640 [details] Patch
Build Bot
Comment 2 2013-05-24 07:27:15 PDT
Comment on attachment 202640 [details] Patch Attachment 202640 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/695030 New failing tests: editing/style/5065910.html editing/undo/undo-after-setting-value.html
Build Bot
Comment 3 2013-05-24 07:27:16 PDT
Created attachment 202819 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Brent Fulgham
Comment 4 2013-06-17 23:18:26 PDT
Comment on attachment 202640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202640&action=review Looks good, but you'll need to land it manually. > Source/JavaScriptCore/ChangeLog:9 > + * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: We no longer use these! > Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:-570 > - WTFSetCrashHook These files are gone now... > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:-569 > - WTFSetCrashHook Ditto...
Note You need to log in before you can comment on or make changes to this bug.