Bug 116621

Summary:	fast/replaced/preferred-widths.html is flaky
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Layout and Rendering	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	aboya, ap, dino, hyatt, ryanhaddad, simon.fraser, zalan
Priority:	P2	Keywords:	LayoutTestFailure
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=153311

Description Ryosuke Niwa 2013-05-22 10:17:35 PDT

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Freplaced%2Fpreferred-widths.html

e.g.
http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/9097

--- /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/fast/replaced/preferred-widths-expected.txt
+++ /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/fast/replaced/preferred-widths-actual.txt
@@ -1,12 +1,31 @@
 Test the effect of percentages widths on the preferred widths of replaced elements.
 
 
-PASS
+FAIL:
+Expected 130 for width, but got 40. 
+Expected 130 for height, but got 30. 
+Expected 120 for width, but got 30. 
+Expected 120 for height, but got 20. 
+
+<div class="container" data-expected-width="130" data-expected-height="130">
+    <img class="min-content" src="resources/square-blue-100x100.png" style="width: 10px; border: 5px solid black; padding: 5px;" data-expected-width="120" data-expected-height="120">
+</div>
  
-PASS
+FAIL:
+Expected 130 for width, but got 40. 
+Expected 130 for height, but got 30. 
+Expected 120 for width, but got 30. 
+Expected 120 for height, but got 20. 
+
+<div class="container" data-expected-width="130" data-expected-height="130">
+    <img class="max-content" src="resources/square-blue-100x100.png" style="width: 10px; border: 5px solid black; padding: 5px;" data-expected-width="120" data-expected-height="120">
+</div>
  
 FAIL:
 Expected 130 for width, but got 30. 
+Expected 130 for height, but got 30. 
+Expected 120 for width, but got 40. 
+Expected 120 for height, but got 20. 
 
 <div class="container" data-expected-width="130" data-expected-height="130">
     <img class="min-content" src="resources/square-blue-100x100.png" style="width: 100%; border: 5px solid black; padding: 5px;" data-expected-width="120" data-expected-height="120">
@@ -14,18 +33,54 @@
  
 FAIL:
 Expected 130 for width, but got 30. 
+Expected 130 for height, but got 30. 
+Expected 120 for width, but got 40. 
+Expected 120 for height, but got 20. 
 
 <div class="container" data-expected-width="130" data-expected-height="130">
     <img class="max-content" src="resources/square-blue-100x100.png" style="width: 100%; border: 5px solid black; padding: 5px;" data-expected-width="120" data-expected-height="120">
 </div>
  
-PASS
+FAIL:
+Expected 75 for height, but got 30. 
+Expected 65 for height, but got 20. 
+
+<div class="container" data-expected-width="55" data-expected-height="75">
+    <img src="resources/square-blue-100x100.png" style="min-width: 25px; width: 100%; border: 5px solid black; padding: 5px;" data-expected-width="65" data-expected-height="65">
+</div>
  
-PASS
+FAIL:
+Expected 75 for height, but got 30. 
+Expected 65 for height, but got 20. 
+
+<div class="container" data-expected-width="55" data-expected-height="75">
+    <img src="resources/square-blue-100x100.png" style="min-width: 25px; width: 100%; border: 5px solid black; padding: 5px;" data-expected-width="65" data-expected-height="65">
+</div>
  
-PASS
+FAIL:
+Expected 50 for height, but got 30. 
+Expected 40 for height, but got 20. 
+
+<div class="container" data-expected-width="30" data-expected-height="50">
+    <img src="resources/square-blue-100x100.png" style="width: 100%; border: 5px solid grey; padding: 5px;" data-expected-width="40" data-expected-height="40">
+</div>
  
-PASS
+FAIL:
+Expected 50 for height, but got 30. 
+Expected 40 for width, but got 20. 
+Expected 40 for height, but got 20. 
+
+<div class="container" data-expected-width="30" data-expected-height="50">
+    <img src="resources/square-blue-100x100.png" style="max-width: 100%; border: 5px solid grey; padding: 5px;" data-expected-width="40" data-expected-height="40">
+</div>
  
-PASS
+FAIL:
+Expected 130 for width, but got 30. 
+Expected 150 for height, but got 30. 
+Expected 140 for width, but got 40. 
+Expected 140 for height, but got 20. 
 
+<div class="container" data-expected-width="130" data-expected-height="150">
+    <img src="resources/square-blue-100x100.png" style="min-width: 100%; border: 5px solid grey; padding: 5px;" data-expected-width="140" data-expected-height="140">
+</div>
+

Comment 1 Alexey Proskuryakov 2016-06-12 22:39:14 PDT

This test lays out in flaky ways even when simply opening it in Safari and reloading several times. Seems like a very real bug.

Comment 2 Ryan Haddad 2016-10-10 14:10:51 PDT

Marked test as flaky on mac in http://trac.webkit.org/projects/webkit/changeset/207022

Comment 3 Alicia Boya García 2018-03-28 08:08:41 PDT

The problem affects other platforms as well, I'll move the change to the global TestExpectations.

Comment 4 Alicia Boya García 2018-03-28 13:05:51 PDT

Moved to global expectations in https://trac.webkit.org/changeset/230034/webkit