| Summary: | [EFL] Back, Forward and Stop should be hidden in context menu | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||
| Component: | WebKit EFL | Assignee: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Michal Pakula vel Rutka
2013-05-22 07:04:25 PDT
Created attachment 202535 [details]
proposed patch
Comment on attachment 202535 [details]
proposed patch
Maybe this decision could be made by a call out to the PopupMenuClient?
(In reply to comment #2) > (From update of attachment 202535 [details]) > Maybe this decision could be made by a call out to the PopupMenuClient? In case of back/forward it is possible, but I am not sure if I can made check inside UIProcess for reload/stop like DocumentLoader::isLoadingInAPISense. Comment on attachment 202535 [details]
proposed patch
One less #ifdef and it makes EFL use more common code which is always good. The items in question were not getting disabled for us anyway so it is best not to show them. r=me but let Gyuyoung have a look before landing as he may be the one who added this #ifdef in the first place.
There was no big reason to show those menu items. It just follows GTK port behavior. If the items doesn't work on EFL port now, I'm fine. Comment on attachment 202535 [details]
proposed patch
I'd like to check API test with patch before landing.
Comment on attachment 202535 [details]
proposed patch
There is no problem on context menu API tests.
Comment on attachment 202535 [details] proposed patch Clearing flags on attachment: 202535 Committed r150575: <http://trac.webkit.org/changeset/150575> All reviewed patches have been landed. Closing bug. |