| Summary: | [Qt] REGRESSION(r149292): broke scrolling in Qt WK2 desktop mode | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||
| Component: | WebKit Qt | Assignee: | Noam Rosenthal <noam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | allan.jensen, andersca, cmarcelo, commit-queue, jamesr, jturcotte, kadam, luiz, ossy, tonikitoo, zarvai, zeno | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Noam Rosenthal
2013-05-22 02:07:56 PDT
Created attachment 202908 [details]
Patch
this fixes the regression, however since the Qt-WK2-desktop mode is a configuration that is not covered at all by tests, I can't guarantee regressions like this won't come back. Created attachment 203043 [details]
Patch
Comment on attachment 203043 [details]
Patch
LGTM
Comment on attachment 203043 [details] Patch Clearing flags on attachment: 203043 Committed r150798: <http://trac.webkit.org/changeset/150798> All reviewed patches have been landed. Closing bug. FYI: It broke ~500 pixel tests on the pixel bot. (In reply to comment #7) > FYI: It broke ~500 pixel tests on the pixel bot. The scrollbar is missing on actual results http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Pixel%20Tests%29/r150800%20%284395%29/results.html (In reply to comment #8) > (In reply to comment #7) > > FYI: It broke ~500 pixel tests on the pixel bot. > > The scrollbar is missing on actual results > http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Pixel%20Tests%29/r150800%20%284395%29/results.html No scrollbar appears in "MiniBrowser --desktop". But there is also no scrollbar with r149291. If the new results without scrollbars are acceptable I will rebaseline them. Is it ok? PNG rebaseline for QT WK2 landed in http://trac.webkit.org/changeset/150961. |