Bug 116596

Summary: [sh4] Remove MacroAssemblerSH4.cpp file
Product: WebKit Reporter: Julien Brianceau <jbriance>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, mark.lam, oliver, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Remove MacroAssemblerSH4.cpp file
none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 none

Julien Brianceau
Reported 2013-05-22 01:06:45 PDT
sh4 port has a MacroAssemblerSH4.cpp file implementing linkCall and repatchCall functions. We should move these implementations to MacroAssemblerSH4.h file, as it is done for other architectures.
Attachments
Remove MacroAssemblerSH4.cpp file (9.40 KB, patch)
2013-05-22 01:12 PDT, Julien Brianceau 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (1002.22 KB, application/zip)
2013-05-22 01:42 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Julien Brianceau
Comment 1 2013-05-22 01:12:24 PDT
Created attachment 202506 [details] Remove MacroAssemblerSH4.cpp file
Build Bot
Comment 2 2013-05-22 01:42:16 PDT
Comment on attachment 202506 [details] Remove MacroAssemblerSH4.cpp file Attachment 202506 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/554077 New failing tests: svg/batik/text/textAnchor.svg
Build Bot
Comment 3 2013-05-22 01:42:17 PDT
Created attachment 202507 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Julien Brianceau
Comment 4 2013-05-22 02:08:38 PDT
Comment on attachment 202506 [details] Remove MacroAssemblerSH4.cpp file mac-wk2 ews error does not seem to be related to this patch
Geoffrey Garen
Comment 5 2013-05-22 09:21:39 PDT
Comment on attachment 202506 [details] Remove MacroAssemblerSH4.cpp file r=me
WebKit Commit Bot
Comment 6 2013-05-22 09:42:08 PDT
Comment on attachment 202506 [details] Remove MacroAssemblerSH4.cpp file Clearing flags on attachment: 202506 Committed r150519: <http://trac.webkit.org/changeset/150519>
WebKit Commit Bot
Comment 7 2013-05-22 09:42:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.