Bug 116583

Summary: [WinCE,WinCairo] RenderThemeWin.cpp need to include FrameSelection.h
Product: WebKit Reporter: Mark Salisbury <mark.salisbury>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed fix
none
Proposed fix
bfulgham: review+
Proposed fix none

Mark Salisbury
Reported 2013-05-21 16:54:59 PDT
Not sure how recently this was introduced - I think WinCairo does not generally build RenderThemeWin.cpp anymore. Anyway, FrameSelection is undefined, probably because it was removed from an upstream include file recently.
Attachments
Proposed fix (992 bytes, patch)
2013-05-21 16:58 PDT, Mark Salisbury 		no flags
DetailsFormatted DiffDiff
Proposed fix (1007 bytes, patch)
2013-05-21 17:16 PDT, Mark Salisbury 		bfulgham: review+
DetailsFormatted DiffDiff
Proposed fix (1006 bytes, patch)
2013-06-04 07:33 PDT, Mark Salisbury 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Salisbury
Comment 1 2013-05-21 16:58:22 PDT
Created attachment 202478 [details] Proposed fix Simple build fix
WebKit Commit Bot
Comment 2 2013-05-21 17:00:53 PDT
Attachment 202478 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderThemeWin.cpp']" exit_code: 1 Source/WebCore/rendering/RenderThemeWin.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Salisbury
Comment 3 2013-05-21 17:16:25 PDT
Created attachment 202480 [details] Proposed fix Added header file in proper alphabetical order.
Brent Fulgham
Comment 4 2013-05-31 22:47:37 PDT
Comment on attachment 202480 [details] Proposed fix r=me
Mark Salisbury
Comment 5 2013-06-04 07:33:34 PDT
Created attachment 203695 [details] Proposed fix Added Brent Fulgham as reviewer. Thanks Brent.
Brent Fulgham
Comment 6 2013-06-05 14:28:37 PDT
Comment on attachment 203695 [details] Proposed fix r=me
WebKit Commit Bot
Comment 7 2013-06-05 14:33:29 PDT
Comment on attachment 203695 [details] Proposed fix Clearing flags on attachment: 203695 Committed r151239: <http://trac.webkit.org/changeset/151239>
WebKit Commit Bot
Comment 8 2013-06-05 14:33:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.