Bug 11658

Summary: KRenderingPaintServer* rework
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch oliver: review+

Nikolas Zimmermann
Reported 2006-11-20 13:08:51 PST
Similiar to the work in patch 11468 (platform/graphics addition), and 11596 (KCanvasFilters split-up)the KRenderingPaintServer* classes has to be reworked. The KRenderingPaintServer classes are moved to platform/graphics/svg, named SVGPaintServer*. Removing the qt/quartz specific KRenderingPaintServer*(Qt/Quartz) which were inherting from the KRenderingPaintServer* classes and reimplemented functions. Now designed just like all other code in platform (adding functions, and the implementations in platform specific subdirs). kcanvas/device/ now only contains KRenderingDevice & KRenderingDeviceContext - to be integrated within platform/graphics/GraphicsContext soon (Eric already started a patch some time ago) Attaching patch soon
Attachments
Initial patch (233.91 KB, patch)
2006-11-20 13:44 PST, Nikolas Zimmermann 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-11-20 13:44:02 PST
Created attachment 11589 [details] Initial patch No new leaks or regressions introduced.
Oliver Hunt
Comment 2 2006-11-20 18:20:07 PST
Comment on attachment 11589 [details] Initial patch looks fine to me
Nikolas Zimmermann
Comment 3 2006-11-21 04:33:03 PST
Landed in r17870. Thanks Oliver for the quick review!
Note You need to log in before you can comment on or make changes to this bug.