Bug 116565 – Avoid layout when only non-ancestors positioned objects are dirty on property access

• Component: CSS
• Status: NEW

[Antti Koivisto]

We may be able to avoid some layouts on offsetLeft and pals.

[Antti Koivisto]

Created attachment 202454 [details]
lets see what breaks

[WebKit Commit Bot]

Attachment 202454 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h']" exit_code: 1
Source/WebCore/dom/Document.cpp:1916:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/dom/Document.cpp:1919:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 202454 [details]
lets see what breaks

Attachment 202454 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/667026

New failing tests:
fast/images/repaint-subrect-grid.html
inspector/timeline/timeline-layout.html
fast/regions/autoheight-two-pass-layout-complex-002.html

[Build Bot]

Created attachment 202807 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Build Bot]

Comment on attachment 202454 [details]
lets see what breaks

Attachment 202454 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/689226

New failing tests:
fast/events/capture-on-target.html
http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
svg/dom/SVGScriptElement/script-load-and-error-events.svg
svg/animations/animate-beginElementAt.svg
animations/animation-hit-test.html
fast/regions/autoheight-two-pass-layout-complex-002.html
plugins/reentrant-update-widget-positions.html
svg/animations/smil-leak-dynamically-added-element-instances.svg
scrollbars/scrollbar-iframe-click-does-not-blur-content.html
animations/animation-hit-test-transform.html
fast/images/repaint-subrect-grid.html
fast/regions/flexbox-in-region-crash.html
inspector/timeline/timeline-layout.html
fast/events/document-elementFromPoint.html
svg/animations/smil-leak-element-instances-noBaseValRef.svg
svg/animations/smil-leak-element-instances.svg
svg/animations/dynamic-modify-attributename-crash.svg
svg/animations/smil-leak-elements.svg
svg/dom/SVGScriptElement/script-onerror-bubbling.svg
animations/simultaneous-start-transform.html
svg/dom/SVGScriptElement/script-reexecution.svg
fast/events/offsetX-offsetY.html

[Build Bot]

Created attachment 203124 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Karl Rackler]

I removed those expectations for fast/events/offsetX-offsetY.html here because the test was passing consistently
https://bug-213863-attachments.webkit.org/attachment.cgi?id=403332