Bug 116549

Summary: [EFL][WK2] Change Ewk_Context_Menu_Item's parent menu to raw pointer
Product: WebKit Reporter: Michal Pakula vel Rutka <mpakulavelrutka>
Component: WebKit EFLAssignee: Michal Pakula vel Rutka <mpakulavelrutka>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, mikhail.pozdnyakov, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114728, 116311    
Attachments:
Description Flags
proposed patch
none
patch none

Michal Pakula vel Rutka
Reported 2013-05-21 09:16:10 PDT
SSIA
Attachments
proposed patch (16.57 KB, patch)
2013-05-21 09:22 PDT, Michal Pakula vel Rutka 		no flags
DetailsFormatted DiffDiff
patch (4.96 KB, patch)
2013-05-22 02:03 PDT, Michal Pakula vel Rutka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michal Pakula vel Rutka
Comment 1 2013-05-21 09:22:00 PDT
Created attachment 202441 [details] proposed patch
Chris Dumez
Comment 2 2013-05-21 11:12:09 PDT
Comment on attachment 202441 [details] proposed patch This seems more like a revert than a proper fix. I think the best solution would be for EwkContextMenuItem::create() / constructor to take a EwkContextMenu* instead of a PassRefPtr<EwkContextMenu>. It is not correct to have the menu own the item and have the item own the menu at the same time.
Michal Pakula vel Rutka
Comment 3 2013-05-22 02:03:54 PDT
Created attachment 202508 [details] patch Instead of removing parent menu from context menu item, RefPtr to parent menu is changed to raw pointer.
Chris Dumez
Comment 4 2013-05-22 02:08:34 PDT
Comment on attachment 202508 [details] patch LGTM. r=me.
WebKit Commit Bot
Comment 5 2013-05-22 02:37:28 PDT
Comment on attachment 202508 [details] patch Clearing flags on attachment: 202508 Committed r150507: <http://trac.webkit.org/changeset/150507>
WebKit Commit Bot
Comment 6 2013-05-22 02:37:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.