Bug 116549

Summary:

[EFL][WK2] Change Ewk_Context_Menu_Item's parent menu to raw pointer

Product:

WebKit

Reporter:

Michal Pakula vel Rutka <mpakulavelrutka>

Component:

WebKit EFL

Assignee:

Michal Pakula vel Rutka <mpakulavelrutka>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, mikhail.pozdnyakov, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

114728, 116311

Attachments:

Description	Flags
proposed patch	none
patch	none

Description Michal Pakula vel Rutka 2013-05-21 09:16:10 PDT

SSIA

Comment 1 Michal Pakula vel Rutka 2013-05-21 09:22:00 PDT

Created attachment 202441 [details]
proposed patch

Comment 2 Chris Dumez 2013-05-21 11:12:09 PDT

Comment on attachment 202441 [details]
proposed patch

This seems more like a revert than a proper fix. I think the best solution would be for EwkContextMenuItem::create() / constructor to take a EwkContextMenu* instead of a PassRefPtr<EwkContextMenu>. It is not correct to have the menu own the item and have the item own the menu at the same time.

Comment 3 Michal Pakula vel Rutka 2013-05-22 02:03:54 PDT

Created attachment 202508 [details]
patch

Instead of removing parent menu from context menu item, RefPtr to parent menu is changed to raw pointer.

Comment 4 Chris Dumez 2013-05-22 02:08:34 PDT

Comment on attachment 202508 [details]
patch

LGTM. r=me.

Comment 5 WebKit Commit Bot 2013-05-22 02:37:28 PDT

Comment on attachment 202508 [details]
patch

Clearing flags on attachment: 202508

Committed r150507: <http://trac.webkit.org/changeset/150507>

Comment 6 WebKit Commit Bot 2013-05-22 02:37:31 PDT

All reviewed patches have been landed.  Closing bug.