Bug 116545

Summary: [BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, commit-queue, rwlbuis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jakob Petsovits
Reported 2013-05-21 08:56:43 PDT
The "viewport" parameter in WebPageCompositor::render() is an artifact of our port's historical development, both unused and unnecessary. We should get rid of it. Also change the name of the "documentContents" parameter to the more descriptive "documentSrcRect". Patch below.
Attachments
Patch (5.97 KB, patch)
2013-05-21 08:58 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Patch (6.05 KB, patch)
2013-05-21 12:02 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Patch (5.92 KB, patch)
2013-05-21 13:28 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2013-05-21 08:58:57 PDT
Created attachment 202437 [details] Patch
Arvid Nilsson
Comment 2 2013-05-21 11:51:59 PDT
Comment on attachment 202437 [details] Patch LGTM, nice cleanup
Jakob Petsovits
Comment 3 2013-05-21 12:02:36 PDT
Created attachment 202455 [details] Patch Mike Fenton recently changed indentations, update patch to apply against current trunk.
Jakob Petsovits
Comment 4 2013-05-21 13:28:38 PDT
Created attachment 202465 [details] Patch Bug 116542 modifies a clashing hunk and with it (probably) not getting in, update the patch to apply against the state of the code without the other patch.
Rob Buis
Comment 5 2013-05-23 20:51:38 PDT
Comment on attachment 202465 [details] Patch Ok.
WebKit Commit Bot
Comment 6 2013-05-23 23:07:35 PDT
Comment on attachment 202465 [details] Patch Clearing flags on attachment: 202465 Committed r150625: <http://trac.webkit.org/changeset/150625>
WebKit Commit Bot
Comment 7 2013-05-23 23:07:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.