Bug 116539

Summary: [BlackBerry] Make screen updates dependent on the existence of a drawing buffer
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, cgarcia, commit-queue, rwlbuis, tonikitoo, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jakob Petsovits
Reported 2013-05-21 08:24:08 PDT
We currently use a suspend counter to ensure that if a target buffer is missing initially, blitting to screen / target buffer will not happen. The patch below reduces complexity by relying on the current state, rather than the suspend counter, which in turn makes it possible to simplify the code in setCompositor().
Attachments
Patch (3.65 KB, patch)
2013-05-21 08:35 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Patch (3.84 KB, patch)
2013-05-21 08:53 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Patch (3.72 KB, patch)
2013-05-24 15:55 PDT, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2013-05-21 08:35:07 PDT
Created attachment 202432 [details] Patch
Jakob Petsovits
Comment 2 2013-05-21 08:53:13 PDT
Created attachment 202436 [details] Patch Whoops, forgot to include the description part of the commit message.
Jakob Petsovits
Comment 3 2013-05-24 15:55:10 PDT
Created attachment 202860 [details] Patch Not sure why the patch didn't like to be applied. It cherry-picked fine from my git branch onto (git-)SVN trunk, ChangeLog aside. Trying again - this time coming straight from the svn/master branch, hopefully the bots like me better this time.
Arvid Nilsson
Comment 4 2013-05-26 21:09:03 PDT
LGTM, passed internal review :)
WebKit Commit Bot
Comment 5 2013-05-26 23:55:01 PDT
Comment on attachment 202860 [details] Patch Clearing flags on attachment: 202860 Committed r150735: <http://trac.webkit.org/changeset/150735>
WebKit Commit Bot
Comment 6 2013-05-26 23:55:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.