Summary: | New Flickr doesn't get fast scrolling but should | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, commit-queue, esprehn+autocc, glenn, simon.fraser, thorton, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2013-05-20 22:43:53 PDT
Created attachment 202379 [details]
Patch
Attachment 202379 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle-expected.txt', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-expected.txt', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle-expected.txt', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html', u'LayoutTests/platform/mac-wk2/tiled-drawing/slow-scrolling.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderObject.cpp']" exit_code: 1
Source/WebCore/rendering/RenderObject.cpp:133: Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Style bot complaint is existing code. Comment on attachment 202379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202379&action=review > Source/WebCore/rendering/RenderObject.cpp:130 > + UNUSED_PARAM(frameView); Seems wrong to have this UNUSED_PARAM be unconditional, when the use of the parameter is conditional. >> Source/WebCore/rendering/RenderObject.cpp:133 >> +#if PLATFORM(QT) > > Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5] I don’t think the style bot is being helpful here. > Source/WebCore/rendering/RenderObject.cpp:2490 > + if (view()->frameView()) { I think we should put the FrameView into a local because it’s used two more times below and the code would be more concise without repeating it. > Source/WebCore/rendering/RenderObject.cpp:2491 > + bool repaintFixedBackgroundsOnScroll = shouldRepaintFixedBackgroundsOnScroll(view()->frameView()); Why the local variable here? I think it makes the code harder to read. (In reply to comment #4) > (From update of attachment 202379 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=202379&action=review > > > Source/WebCore/rendering/RenderObject.cpp:130 > > + UNUSED_PARAM(frameView); > > Seems wrong to have this UNUSED_PARAM be unconditional, when the use of the parameter is conditional. I thought it was simpler than having the UNUSED_PARAM inside an #else; it's harmless to have it when the param is actually used, but I can clean this up. > > Do not add platform specific code in WebCore outside of platform. [build/webcore_platform_layering_violation] [5] > > I don’t think the style bot is being helpful here. Agreed! > > Source/WebCore/rendering/RenderObject.cpp:2490 > > + if (view()->frameView()) { > > I think we should put the FrameView into a local because it’s used two more times below and the code would be more concise without repeating it. Will do. > > Source/WebCore/rendering/RenderObject.cpp:2491 > > + bool repaintFixedBackgroundsOnScroll = shouldRepaintFixedBackgroundsOnScroll(view()->frameView()); > > Why the local variable here? I think it makes the code harder to read. I can remove this. Simon |