Bug 116496
| Summary: | Fix crash when trying to get bounding box of node without a renderer | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, cfleizach, enrica, jdiggs, samuel_white, webkit-bug-importer |
| Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/f489bf99677ac37abb2fb3510cb50cb4ea22e3e4
It's obviously not possible to get the bounding box of an unrendered
node; the null check was accidentally reversed when two functions
were combined in the previous change.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/16014040>
Joanmarie Diggs
(In reply to comment #0)
> Consider merging
> https://chromium.googlesource.com/chromium/blink/+/
> f489bf99677ac37abb2fb3510cb50cb4ea22e3e4
>
> It's obviously not possible to get the bounding box of an unrendered
> node; the null check was accidentally reversed when two functions
> were combined in the previous change.
Are you suggesting we merge the previous change:
https://chromiumcodereview.appspot.com/14740025/
If it's just fixing the null check that was accidentally reversed, we don't have a need:
https://trac.webkit.org/browser/trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp#L850
Ahmad Saleem
This seems that the code has changed now: https://github.com/WebKit/WebKit/blob/5b655cd9d573ea496ed4bc3972080ce932e5ee10/Source/WebCore/accessibility/AccessibilityRenderObject.cpp#L887
Do we need this now? Thanks!
Ahmad Saleem
(In reply to Ahmad Saleem from comment #3)
> This seems that the code has changed now:
> https://github.com/WebKit/WebKit/blob/
> 5b655cd9d573ea496ed4bc3972080ce932e5ee10/Source/WebCore/accessibility/
> AccessibilityRenderObject.cpp#L887
>
> Do we need this now? Thanks!
https://github.com/WebKit/WebKit/blob/5b655cd9d573ea496ed4bc3972080ce932e5ee10/Source/WebCore/accessibility/AccessibilityRenderObject.cpp#L1203
^ Also