Bug 116420 – [Mac] REGRESSION (r107844): text/url-list handling in Clipboard’s getData is wrong

• Component: Platform
• Status: RESOLVED CONFIGURATION CHANGED

[Darin Adler]

I noticed a mistake by code inspection. Only the last URL in the list works. And I guess we have no regression tests for this. I suppose I’ll have to make one.

[Darin Adler]

Created attachment 202246 [details]
Patch

[Darin Adler]

No review flag because there’s no test yet.

[Sam Weinig]

(In reply to comment #2)
> No review flag because there’s no test yet.

I think setData is wrong as well.  What we probably should be doing is parsing the string in setData to get the list of URLs (the format for text/uri-list specified at http://tools.ietf.org/html/rfc2483#section-5) and then we should be writing those URLs to the NSPasteboard using [pasteboard writeObjects:nsArrayOfURLs];

[Darin Adler]

Wenson, any interest in tackling this?

You can see reading Pasteboard::readString that it has a loop, but throws away the results from all but the last iteration of the loop.

[Wenson Hsieh]

(In reply to Darin Adler from comment #4)
> Wenson, any interest in tackling this?
> 
> You can see reading Pasteboard::readString that it has a loop, but throws
> away the results from all but the last iteration of the loop.

Yep, sounds like something I can look into!

[Darin Adler]

This code and feature was removed in r222257 so this no longer needs to be done.

[Darin Adler]

https://trac.webkit.org/changeset/222257

[Radar WebKit Bug Importer]

<rdar://problem/34694155>