Bug 116413

Summary: Text does not get truncated properly in vertical writing mode when overflow:hidden and text-overflow:ellipsis are set.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, commit-queue, esprehn+autocc, glenn, gtk-ews, hyatt, karlcow, robert, webkit-bug-importer, xan.lopez, yuki.sekiguchi, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test case
none
Patch
none
Patch
none
Patch
beidson: review-
vertical overflow with ellipsis test
none
rendering in Safari, firefox, chrome none

Description zalan 2013-05-19 08:12:32 PDT
div {
    -webkit-writing-mode: vertical-rl; 
    text-overflow: ellipsis;
    overflow: hidden;
    white-space: nowrap;
    border: solid 1px red;
    height: 200px;
  }

  input {
    float: right;
  }

<div><input type="text">Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. 
</div>

In vertical writing mode, we should truncate the text at the edge of the input box and apply ellipsis in vertical writing mode. Currently we fail to do both.
Comment 1 zalan 2013-05-19 08:13:21 PDT
Created attachment 202234 [details]
test case
Comment 2 Yuki Sekiguchi 2013-06-10 04:53:28 PDT
Created attachment 204152 [details]
Patch
Comment 3 Build Bot 2013-06-10 05:26:29 PDT
Comment on attachment 204152 [details]
Patch

Attachment 204152 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/811267
Comment 4 kov's GTK+ EWS bot 2013-06-10 09:11:59 PDT
Comment on attachment 204152 [details]
Patch

Attachment 204152 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/753564
Comment 5 Yuki Sekiguchi 2013-06-10 19:40:04 PDT
Created attachment 204278 [details]
Patch
Comment 6 kov's GTK+ EWS bot 2013-06-11 10:59:14 PDT
Comment on attachment 204278 [details]
Patch

Attachment 204278 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/784534
Comment 7 Yuki Sekiguchi 2013-06-19 00:39:04 PDT
Created attachment 204972 [details]
Patch
Comment 8 Brady Eidson 2016-05-24 22:00:56 PDT
Comment on attachment 204972 [details]
Patch

Assuming that patches for review since 2013 are stale, r-
Comment 9 Karl Dubost 2022-06-02 22:34:26 PDT
Created attachment 459995 [details]
vertical overflow with ellipsis test

This is a slightly better test which would work in all browsers by avoiding prefixes.
Comment 10 Karl Dubost 2022-06-02 22:39:10 PDT
Created attachment 459996 [details]
rendering in Safari, firefox, chrome

* firefox and chrome show the ellipsis
* safari doesn't cut the box at the same length and doesn't show the ellipsis
Comment 11 Radar WebKit Bug Importer 2022-06-02 22:39:46 PDT
<rdar://problem/94330690>
Comment 12 Ahmad Saleem 2023-02-17 09:27:03 PST
WebKit ToT (260447@main) now show "ellipsis" but still does not cut at right length at least for this test case:

https://bug-116413-attachments.webkit.org/attachment.cgi?id=459995

Just wanted to show the little progress on this bug.
Comment 13 zalan 2023-02-17 10:03:17 PST
ok, so original bug is fixed (IFC progression). Karl's test case is slightly different as it relies on a relative height unit (ch), which we don't compute properly. Will open a new bug on that.
Comment 14 zalan 2023-02-17 10:09:37 PST
see bug 252490