Bug 116407

Summary: Remove copy of ICU headers from WebKit
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, buildbot, don.olmstead, jbedard, jlewis3, keith_miller, mark.lam, mmaxfield, msaboff, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174299
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
WIP
none
Patch
none
Patch
none
Patch
none
Patch
achristensen: review+
Patch for committing none

Anders Carlsson
Reported 2013-05-18 18:47:35 PDT
Remove copy of ICU headers from WebKit
Attachments
WIP (3.15 MB, patch)
2017-07-02 17:09 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (5.91 MB, patch)
2017-07-02 17:48 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (5.19 MB, patch)
2017-07-02 22:26 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (5.93 MB, patch)
2017-07-02 22:54 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (5.93 MB, patch)
2017-07-02 23:07 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (5.93 MB, patch)
2017-07-02 23:34 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (5.93 MB, patch)
2017-07-03 10:58 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (5.93 MB, patch)
2017-07-03 11:27 PDT, Myles C. Maxfield 		achristensen: review+
DetailsFormatted DiffDiff
Patch for committing (5.93 MB, patch)
2017-07-03 17:12 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-19 11:41:48 PDT
Two thoughts: 1. Looks like we could install the ICU headers inside WTF. 2. There’s also a copy of ICU headers in WebCore.
Alexey Proskuryakov
Comment 2 2013-05-19 17:03:08 PDT
Would we have to include them as <wtf/icu/whatever.h> then? Unsure if it's worth it.
Alexey Proskuryakov
Comment 3 2013-06-16 14:27:29 PDT
*** Bug 117672 has been marked as a duplicate of this bug. ***
Myles C. Maxfield
Comment 4 2017-07-02 17:09:18 PDT
Created attachment 314428 [details] WIP
Myles C. Maxfield
Comment 5 2017-07-02 17:48:27 PDT
Created attachment 314432 [details] Patch
Myles C. Maxfield
Comment 6 2017-07-02 22:26:35 PDT
Created attachment 314448 [details] Patch
Myles C. Maxfield
Comment 7 2017-07-02 22:54:03 PDT
Created attachment 314449 [details] WIP
Myles C. Maxfield
Comment 8 2017-07-02 23:07:31 PDT
Created attachment 314452 [details] Patch
Myles C. Maxfield
Comment 9 2017-07-02 23:34:10 PDT
Created attachment 314456 [details] Patch
Myles C. Maxfield
Comment 10 2017-07-03 10:58:05 PDT
Created attachment 314497 [details] Patch
Myles C. Maxfield
Comment 11 2017-07-03 11:27:21 PDT
Created attachment 314501 [details] Patch
Alex Christensen
Comment 12 2017-07-03 14:15:26 PDT
There are a few places we include <wtf/unicode/whatever.h> and we should probably change those to be more consistent. Also, we should change a few includes of UTF8.h to utf8.h Also, I think it would be worth making open source webkit and apple internal webkit use the same icu headers. We will have to maintain the open source headers anyways, and we have better public testing of those headers.
Alex Christensen
Comment 13 2017-07-03 14:34:33 PDT
Nope, wtf/unicode/UTF8.h and icu's utf8.h are different files with different meanings. There's no problem there.
Alex Christensen
Comment 14 2017-07-03 14:39:28 PDT
r=me I still think we should keep open source and internal builds the same here.
Jonathan Bedard
Comment 15 2017-07-03 15:57:04 PDT
I committed this on Myles' request since I have an SVN checkout: <https://trac.webkit.org/changeset/219103/webkit>
Matt Lewis
Comment 16 2017-07-03 16:12:26 PDT
Reverted r219103 for reason: Caused multiple build failures. Committed r219104: <http://trac.webkit.org/changeset/219104>
Myles C. Maxfield
Comment 17 2017-07-03 17:12:25 PDT
Created attachment 314541 [details] Patch for committing
Build Bot
Comment 18 2017-07-03 17:23:44 PDT
Attachment 314541 [details] did not pass style-queue: ERROR: Source/WTF/ChangeLog:249: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: spoof [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 154 files If any of these errors are false positives, please file a bug against check-webkit-style.
Myles C. Maxfield
Comment 19 2017-07-05 14:13:26 PDT
Committed r219155: <http://trac.webkit.org/changeset/219155>
Note You need to log in before you can comment on or make changes to this bug.