| Summary: | [GTK] [CMake] Build the plugin process against GTK+ 2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
| Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, gustavo, gyuyoung.kim, rakuco | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 115966 | ||||||||
| Attachments: |
|
||||||||
|
Description
Martin Robinson
2013-05-17 19:29:58 PDT
Created attachment 219061 [details]
Patch
Created attachment 219298 [details]
Patch fixing small dependency issue
Comment on attachment 219298 [details] Patch fixing small dependency issue View in context: https://bugs.webkit.org/attachment.cgi?id=219298&action=review Not for review yet? > Source/WebKit2/PlatformGTK.cmake:484 > + # FIXME: We should figure out a way to avoid compiling files that are common between the plugin > + # process and WebKit2 only once instead of recompiling them for the plugin process. Maybe build them into an intermediate library that is linked by both? (In reply to comment #3) > (From update of attachment 219298 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219298&action=review > > Not for review yet? Oops! webkit-patch was broken recently and I uploaded it manually. > > Source/WebKit2/PlatformGTK.cmake:484 > > + # FIXME: We should figure out a way to avoid compiling files that are common between the plugin > > + # process and WebKit2 only once instead of recompiling them for the plugin process. > > Maybe build them into an intermediate library that is linked by both? I think that's the best solution. It requires removing the files from the shared source list and then adding them to an intermediate library. It seemed a bit too much for this patch, so I hope it can be tackled later. Comment on attachment 219298 [details] Patch fixing small dependency issue View in context: https://bugs.webkit.org/attachment.cgi?id=219298&action=review >>> Source/WebKit2/PlatformGTK.cmake:484 >>> + # process and WebKit2 only once instead of recompiling them for the plugin process. >> >> Maybe build them into an intermediate library that is linked by both? > > I think that's the best solution. It requires removing the files from the shared source list and then adding them to an intermediate library. It seemed a bit too much for this patch, so I hope it can be tackled later. Absolutely! Committed r160728: <http://trac.webkit.org/changeset/160728> |