| Summary: | Windows port segfaults on startup | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Gibson <dgibson77> | ||||||
| Component: | WebCore Misc. | Assignee: | Don Gibson <dgibson77> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 420+ | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Attachments: |
|
||||||||
|
Description
Don Gibson
2006-11-17 11:28:45 PST
Created attachment 11553 [details]
patch v1
This fixes the segfault on startup and a similar segfault when a URL is typed into the address bar, by stubbing EditorClientWin and FrameLoaderClientWin.
I don't think clicking on links works; that's probably due to my having stubbed FrameLoaderClientWin instead of implementing it properly.
Comment on attachment 11553 [details]
patch v1
Despite what I said on IRC, I actually see 3 issues.
- FrameLoaderClientWin.h needs a newline at the end.
- As long as we are making new files, we might as well follow the guidelines as closely as possible. So, in FrameLoaderClientWin.h please indent all of the class declaration.
- Use '0' instead of 'NULL'.
Created attachment 11556 [details] patch v2 Updated to fix review comments. Also fixes these issues in the code checked in in r17816. Comment on attachment 11556 [details]
patch v2
Looks good, r+. I would only ask that the committer remove the line with "WARNING: NO TEST CASES ADDED OR CHANGED" on it in the ChangeLog.
Committed revision 17847. |