Bug 116308

Summary: Get rid of [ConstructorParameters] extended attributes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Severity: Normal CC: ap, benjamin, commit-queue, darin, ggaren, haraken, laszlo.gombos, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/2006/webapi/WebIDL/#es-interface-call
Description Flags
Patch none

Description Chris Dumez 2013-05-17 05:58:53 PDT
If we specify arguments to [CustomConstructor] extended attribute (similarly to [Constructor]), then we no longer need the [ConstructorParameters] extended attribute to determine the constructor length.

This is less error prone, leads to more readable IDL, and more consistent with [Constructor] extended attribute. This also reduces the number of WebKit specific IDL attributes, which is always good.
Comment 1 Chris Dumez 2013-05-17 07:08:44 PDT
FYI, I already did the same thing in Blink:
Comment 2 Chris Dumez 2013-05-17 07:20:52 PDT
Created attachment 202082 [details]
Comment 3 Kentaro Hara 2013-05-17 07:26:02 PDT
Comment on attachment 202082 [details]

Looks great!
Comment 4 WebKit Commit Bot 2013-05-17 13:05:24 PDT
Comment on attachment 202082 [details]

Clearing flags on attachment: 202082

Committed r150292: <http://trac.webkit.org/changeset/150292>
Comment 5 WebKit Commit Bot 2013-05-17 13:05:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2013-05-17 14:38:19 PDT
Updated WebKit IDL wiki accordingly: