Bug 116308

Summary: Get rid of [ConstructorParameters] extended attributes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, darin, ggaren, haraken, laszlo.gombos, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/2006/webapi/WebIDL/#es-interface-call
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-05-17 05:58:53 PDT
If we specify arguments to [CustomConstructor] extended attribute (similarly to [Constructor]), then we no longer need the [ConstructorParameters] extended attribute to determine the constructor length. This is less error prone, leads to more readable IDL, and more consistent with [Constructor] extended attribute. This also reduces the number of WebKit specific IDL attributes, which is always good.
Attachments
Patch (15.25 KB, patch)
2013-05-17 07:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-05-17 07:08:44 PDT
FYI, I already did the same thing in Blink: https://src.chromium.org/viewvc/blink?view=rev&revision=148663
Chris Dumez
Comment 2 2013-05-17 07:20:52 PDT
Created attachment 202082 [details] Patch
Kentaro Hara
Comment 3 2013-05-17 07:26:02 PDT
Comment on attachment 202082 [details] Patch Looks great!
WebKit Commit Bot
Comment 4 2013-05-17 13:05:24 PDT
Comment on attachment 202082 [details] Patch Clearing flags on attachment: 202082 Committed r150292: <http://trac.webkit.org/changeset/150292>
WebKit Commit Bot
Comment 5 2013-05-17 13:05:28 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 6 2013-05-17 14:38:19 PDT
Updated WebKit IDL wiki accordingly: http://trac.webkit.org/wiki/WebKitIDL?action=diff&version=117&old_version=116
Note You need to log in before you can comment on or make changes to this bug.