| Summary: | Frame flattening: crash when child iframe is removed during beforeload. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, koivisto, rniwa | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
zalan
2013-05-16 05:24:07 PDT
Created attachment 201946 [details]
Patch
Comment on attachment 201946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201946&action=review > Source/WebCore/page/FrameView.cpp:2660 > + // layout() protects FrameView(), but it still can get destroyed, when updateWidgets() FrameView() -> FrameView (and some unneeded commas) Created attachment 201948 [details]
Patch
Comment on attachment 201948 [details] Patch Attachment 201948 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/494098 New failing tests: fast/frames/flattening/crash-remove-iframe-during-object-beforeload.html Created attachment 202009 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Created attachment 202232 [details]
Patch
Comment on attachment 202232 [details] Patch Attachment 202232 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/515134 New failing tests: fast/frames/flattening/crash-remove-iframe-during-object-beforeload.html Created attachment 202266 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Created attachment 203960 [details]
Patch
Comment on attachment 203960 [details] Patch Clearing flags on attachment: 203960 Committed r151312: <http://trac.webkit.org/changeset/151312> All reviewed patches have been landed. Closing bug. |