|Summary:||Port functions for path handling to Windows CE in FileSystemWin|
|Product:||WebKit||Reporter:||Patrick R. Gansterer <paroga>|
|Component:||Platform||Assignee:||Patrick R. Gansterer <paroga>|
|Severity:||Normal||CC:||ap, bfulgham, commit-queue, darin|
|Version:||528+ (Nightly build)|
Description Patrick R. Gansterer 2013-05-15 23:31:39 PDT
Port funcions for pathhandling to Windows CE in FileSystemWin
Comment 3 Alexey Proskuryakov 2013-05-16 09:44:06 PDT
I'm surprised by the direction of this patch. Aren't we usually changing code in the opposite direction, from ifdefs to separate files for each platform?
Comment 4 Patrick R. Gansterer 2013-05-16 10:41:48 PDT
(In reply to comment #3) > I'm surprised by the direction of this patch. Aren't we usually changing code in the opposite direction, from ifdefs to separate files for each platform? WinCE is more like a special version of Windows. If you look at the current Win.cpp files you find many of this kind of #if, since they share 95 percent of the code and imho it would be overkill to do it with different files. Also it's in the _platform_ directory, where it should be ok. It like a BUILDING_FOR_LION guard, where you have no extra files too.
Comment 5 WebKit Commit Bot 2013-05-16 19:46:50 PDT
Comment on attachment 201953 [details] Patch Clearing flags on attachment: 201953 Committed r150231: <http://trac.webkit.org/changeset/150231>
Comment 6 WebKit Commit Bot 2013-05-16 19:46:52 PDT
All reviewed patches have been landed. Closing bug.