Bug 116208

Summary: Port functions for path handling to Windows CE in FileSystemWin
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2013-05-15 23:31:39 PDT
Port funcions for pathhandling to Windows CE in FileSystemWin
Attachments
Patch (2.50 KB, patch)
2013-05-15 23:37 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2013-05-16 07:18 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-05-15 23:37:20 PDT
Created attachment 201926 [details] Patch
Patrick R. Gansterer
Comment 2 2013-05-16 07:18:15 PDT
Created attachment 201953 [details] Patch
Alexey Proskuryakov
Comment 3 2013-05-16 09:44:06 PDT
I'm surprised by the direction of this patch. Aren't we usually changing code in the opposite direction, from ifdefs to separate files for each platform?
Patrick R. Gansterer
Comment 4 2013-05-16 10:41:48 PDT
(In reply to comment #3) > I'm surprised by the direction of this patch. Aren't we usually changing code in the opposite direction, from ifdefs to separate files for each platform? WinCE is more like a special version of Windows. If you look at the current Win.cpp files you find many of this kind of #if, since they share 95 percent of the code and imho it would be overkill to do it with different files. Also it's in the _platform_ directory, where it should be ok. It like a BUILDING_FOR_LION guard, where you have no extra files too.
WebKit Commit Bot
Comment 5 2013-05-16 19:46:50 PDT
Comment on attachment 201953 [details] Patch Clearing flags on attachment: 201953 Committed r150231: <http://trac.webkit.org/changeset/150231>
WebKit Commit Bot
Comment 6 2013-05-16 19:46:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.