Bug 116202

Summary: [wk2] Minimum layout width is lost if the WebProcess crashes
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ap: review+
patch darin: review+

Description Tim Horton 2013-05-15 19:04:04 PDT 
We currently only send the minimum layout width to the WebProcess when the property is set. We also need to send it when the WebProcess is brought up, so that if the WebProcess crashes we send it back over again.

<rdar://problem/13202320>
Comment 1 Tim Horton 2013-05-15 19:08:21 PDT 
Created attachment 201911 [details]
patch
Comment 2 Alexey Proskuryakov 2013-05-15 19:10:33 PDT 
Comment on attachment 201911 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201911&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:539
> +    m_process->send(Messages::WebPage::SetMinimumLayoutWidth(m_minimumLayoutWidth), m_pageID, 0);

Can this be part of creation parameters, to avoid potential races?
Comment 3 Tim Horton 2013-05-15 19:11:44 PDT 
Comment on attachment 201911 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201911&action=review

>> Source/WebKit2/UIProcess/WebPageProxy.cpp:539
>> +    m_process->send(Messages::WebPage::SetMinimumLayoutWidth(m_minimumLayoutWidth), m_pageID, 0);
> 
> Can this be part of creation parameters, to avoid potential races?

Aha! I knew there must be an existing mechanism for this. Will fix.
Comment 4 Tim Horton 2013-05-16 12:03:59 PDT 
Created attachment 201980 [details]
patch
Comment 5 Tim Horton 2013-05-16 12:08:29 PDT 
http://trac.webkit.org/changeset/150197