Bug 116176

Summary: Move drag-specific Clipboard functions inside ENABLE(DRAG_SUPPORT)
Product: WebKit Reporter: Darin Adler <darin>
Component: PlatformAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 115980, 116181    
Attachments:
Description Flags
Patch kling: review+, commit-queue: commit-queue-

Darin Adler
Reported 2013-05-15 12:30:45 PDT
Move drag-specific Clipboard functions inside ENABLE(DRAG_SUPPORT)
Attachments
Patch (3.94 KB, patch)
2013-05-15 12:35 PDT, Darin Adler 		kling: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-05-15 12:35:29 PDT
Created attachment 201864 [details] Patch
Andreas Kling
Comment 2 2013-05-15 13:47:21 PDT
Comment on attachment 201864 [details] Patch r=me mac-wk2 ews says it can't apply the patch. CQing anyway, let's see how it fares.
WebKit Commit Bot
Comment 3 2013-05-15 14:51:19 PDT
Comment on attachment 201864 [details] Patch Rejecting attachment 201864 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 201864, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: --reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/Clipboard.cpp Hunk #1 FAILED at 338. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/dom/Clipboard.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/481211
Darin Adler
Comment 4 2013-05-15 21:36:53 PDT
Committed r150176: <http://trac.webkit.org/changeset/150176>
Note You need to log in before you can comment on or make changes to this bug.