| Summary: | Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, kadam, ossy, webkit-ews, zarvai | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2013-05-14 20:41:46 PDT
Created attachment 201786 [details]
Patch
Attachment 201786 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/C/WKPage.cpp', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.messages.in', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj', u'Tools/TestWebKitAPI/Tests/WebKit2/WillLoad.cpp', u'Tools/TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp', u'Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp']" exit_code: 1
Source/WebKit2/UIProcess/WebPageProxy.h:290: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 201786 [details] Patch Attachment 201786 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/477309 Committed r150242: <http://trac.webkit.org/changeset/150242> (In reply to comment #4) > Committed r150242: <http://trac.webkit.org/changeset/150242> cc Qt guys, because it broke the build. (In reply to comment #5) > (In reply to comment #4) > > Committed r150242: <http://trac.webkit.org/changeset/150242> > > cc Qt guys, because it broke the build. Build fix for Qt landed in http://trac.webkit.org/changeset/150245 |