Bug 116132

Summary: Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kadam, ossy, webkit-ews, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+, webkit-ews: commit-queue-

Sam Weinig
Reported 2013-05-14 20:41:46 PDT
Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
Attachments
Patch (54.51 KB, patch)
2013-05-14 20:45 PDT, Sam Weinig 		andersca: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-05-14 20:45:27 PDT
Created attachment 201786 [details] Patch
WebKit Commit Bot
Comment 2 2013-05-14 20:46:35 PDT
Attachment 201786 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/C/WKPage.cpp', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.messages.in', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj', u'Tools/TestWebKitAPI/Tests/WebKit2/WillLoad.cpp', u'Tools/TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp', u'Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp']" exit_code: 1 Source/WebKit2/UIProcess/WebPageProxy.h:290: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2013-05-14 20:52:25 PDT
Comment on attachment 201786 [details] Patch Attachment 201786 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/477309
Sam Weinig
Comment 4 2013-05-16 21:33:51 PDT
Committed r150242: <http://trac.webkit.org/changeset/150242>
Csaba Osztrogonác
Comment 5 2013-05-17 00:14:11 PDT
(In reply to comment #4) > Committed r150242: <http://trac.webkit.org/changeset/150242> cc Qt guys, because it broke the build.
Zoltan Arvai
Comment 6 2013-05-17 03:07:22 PDT
(In reply to comment #5) > (In reply to comment #4) > > Committed r150242: <http://trac.webkit.org/changeset/150242> > > cc Qt guys, because it broke the build. Build fix for Qt landed in http://trac.webkit.org/changeset/150245
Note You need to log in before you can comment on or make changes to this bug.