Bug 116128

Summary: [GTK] Add support for building WebCore to the cmake build
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gns, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gns: review+

Description Martin Robinson 2013-05-14 16:41:47 PDT
This is the next step on the path to getting WebKit2 building.
Comment 1 Martin Robinson 2013-05-14 17:12:17 PDT
Created attachment 201773 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-05-16 10:31:54 PDT
Comment on attachment 201773 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201773&action=review

> Source/WebCore/ChangeLog:9
> +        * platform/gtk/GtkVersioning.c: Include "config.h" since because we removed

since because

> Source/WebCore/PlatformGTK.cmake:291
> +    set_source_files_properties(platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp PROPERTIES COMPILE_DEFINITIONS "GLIB_DISABLE_DEPRECATION_WARNINGS=1")

This is a pretty neat feature of cmake, I must say.

> Source/cmake/OptionsGTK.cmake:126
> +CHECK_INCLUDE_FILES("GL/glx.h" GLX_FOUND)

I haven't figured out the upper/lowercase rules 100% yet, but this feels like it should be lower.
Comment 3 Martin Robinson 2013-05-16 11:18:44 PDT
Committed r150189: <http://trac.webkit.org/changeset/150189>