Bug 116105 – [WK2][QT][EFL] Sync contents size between WebProcess and UIProcess.

• Component: WebKit2
• Status: RESOLVED WONTFIX

[JungJik Lee]

this issue is occurred only in EFL, but it can be occurred in both QT and EFL.
this issue is that when MiniBrowser launchs with html file,
WebChromeClient send the contents size to UIProcess.
However because it's not sync type message, there is a time gap between WebProcess and UIProcess.
So if we send the contents size message to UIProcess more than twice fast,
UIProcess can not handle the messages at right time.

Like this,
WEBPROCESS virtual void WebKit::WebChromeClient::contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const 127 8
WEBPROCESS virtual void WebKit::WebChromeClient::contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const 800 564
UIPROCESS void WebKit::PageViewportController::didChangeContentsSize(const WebCore::IntSize&) 127 8
UIPROCESS void WebKit::PageViewportController::didChangeContentsSize(const WebCore::IntSize&) 800 564

this cause another problem In EFL MiniBrowse >
https://bugs.webkit.org/show_bug.cgi?id=114496

Miss-match the contents size between WebProcess-side and UIProcess-side makes a huge scale factor.
this patch is for changing the DidChangeContentsSize message type to sync message type.

[JungJik Lee]

(In reply to comment #0)
> this issue is occurred only in EFL, but it can be occurred in both QT and EFL.
> this issue is that when MiniBrowser launchs with html file,
> WebChromeClient send the contents size to UIProcess.
> However because it's not sync type message, there is a time gap between WebProcess and UIProcess.
> So if we send the contents size message to UIProcess more than twice fast,
> UIProcess can not handle the messages at right time.
> 
> Like this,
> WEBPROCESS virtual void WebKit::WebChromeClient::contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const 127 8
> WEBPROCESS virtual void WebKit::WebChromeClient::contentsSizeChanged(WebCore::Frame*, const WebCore::IntSize&) const 800 564
> UIPROCESS void WebKit::PageViewportController::didChangeContentsSize(const WebCore::IntSize&) 127 8
> UIPROCESS void WebKit::PageViewportController::didChangeContentsSize(const WebCore::IntSize&) 800 564
> 
> this cause another problem In EFL MiniBrowse >
> https://bugs.webkit.org/show_bug.cgi?id=114496
Wrong URL > I mean this issue,https://bugs.webkit.org/show_bug.cgi?id=114947 .

> 
> Miss-match the contents size between WebProcess-side and UIProcess-side makes a huge scale factor.
> this patch is for changing the DidChangeContentsSize message type to sync message type.

[JungJik Lee]

Created attachment 201714 [details]
proposal patch

[Benjamin Poulain]

Comment on attachment 201714 [details]
proposal patch

This is definitely not okay.
We are removing sync messages from WebKit2.

This has also no test.

[JungJik Lee]

(In reply to comment #3)
> (From update of attachment 201714 [details])
> This is definitely not okay.
> We are removing sync messages from WebKit2.
> 
> This has also no test.
If we have a plan to remove sync messages, then I would find another way for this issue. Thank you for a review.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.