| Summary: | [curl] Add support for HttpOnly cookies | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Szabolcs David <davidsz> | ||||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, galpeter, kadam | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Szabolcs David
2013-05-14 05:43:50 PDT
Created attachment 201705 [details]
Implementation
Attachment 201705 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/curl/CookieJarCurl.cpp']" exit_code: 1
Source/WebCore/platform/network/curl/CookieJarCurl.cpp:75: Missing space before ( in if( [whitespace/parens] [5]
Source/WebCore/platform/network/curl/CookieJarCurl.cpp:129: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 201707 [details]
Fixed style issues
Comment on attachment 201707 [details]
Fixed style issues
Very nice! r=me.
Comment on attachment 201707 [details] Fixed style issues Rejecting attachment 201707 [details] from commit-queue. New failing tests: compositing/overflow/overflow-compositing-descendant.html compositing/reflections/load-video-in-reflection.html Full output: http://webkit-queues.appspot.com/results/465834 Created attachment 201769 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Note: the Mac mountain lion build does not use the cURL library. This patch cannot be related to that bot failure. (In reply to comment #7) > Note: the Mac mountain lion build does not use the cURL library. This patch cannot be related to that bot failure. Yes, that's true. I'll get a committer to land this. Committed r150103: <http://trac.webkit.org/changeset/150103> |