Bug 116102

Summary:

[curl] Add support for HttpOnly cookies

Product:

WebKit

Reporter:

Szabolcs David <davidsz>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, galpeter, kadam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Implementation	none
Fixed style issues	bfulgham: review+, commit-queue: commit-queue-
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion	none

Szabolcs David

Reported 2013-05-14 05:43:50 PDT

The curl implementation does not supports access to HttpOnly cookies.

Attachments
Implementation (4.20 KB, patch) 2013-05-14 05:49 PDT, Szabolcs David	no flags	Details Formatted Diff Diff
Fixed style issues (4.20 KB, patch) 2013-05-14 05:58 PDT, Szabolcs David	bfulgham: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (669.05 KB, application/zip) 2013-05-14 16:26 PDT, WebKit Commit Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Szabolcs David

Comment 1 2013-05-14 05:49:02 PDT

Created attachment 201705 [details] Implementation

WebKit Commit Bot

Comment 2 2013-05-14 05:51:36 PDT

Attachment 201705 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/curl/CookieJarCurl.cpp']" exit_code: 1 Source/WebCore/platform/network/curl/CookieJarCurl.cpp:75: Missing space before ( in if( [whitespace/parens] [5] Source/WebCore/platform/network/curl/CookieJarCurl.cpp:129: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Szabolcs David

Comment 3 2013-05-14 05:58:20 PDT

Created attachment 201707 [details] Fixed style issues

Brent Fulgham

Comment 4 2013-05-14 13:02:43 PDT

Comment on attachment 201707 [details] Fixed style issues Very nice! r=me.

WebKit Commit Bot

Comment 5 2013-05-14 16:26:51 PDT

Comment on attachment 201707 [details] Fixed style issues Rejecting attachment 201707 [details] from commit-queue. New failing tests: compositing/overflow/overflow-compositing-descendant.html compositing/reflections/load-video-in-reflection.html Full output: http://webkit-queues.appspot.com/results/465834

WebKit Commit Bot

Comment 6 2013-05-14 16:26:52 PDT

Created attachment 201769 [details] Archive of layout-test-results from webkit-cq-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Brent Fulgham

Comment 7 2013-05-14 18:55:00 PDT

Note: the Mac mountain lion build does not use the cURL library. This patch cannot be related to that bot failure.

Peter Gal

Comment 8 2013-05-15 00:26:14 PDT

(In reply to comment #7) > Note: the Mac mountain lion build does not use the cURL library. This patch cannot be related to that bot failure. Yes, that's true. I'll get a committer to land this.

Ádám Kallai

Comment 9 2013-05-15 00:37:40 PDT

Committed r150103: <http://trac.webkit.org/changeset/150103>

Note You need to log in before you can comment on or make changes to this bug.