Bug 116099

Summary: [Qt] UrlLoader::loadNext is broken in MiniBrowser
Product: WebKit Reporter: Hyungchan Kim <inlinechan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: allan.jensen, commit-queue, hausmann, jturcotte
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Hyungchan Kim 2013-05-14 05:13:28 PDT
[Qt] UrlLoader::loadNext is broken in MiniBrowser
Comment 1 Hyungchan Kim 2013-05-14 05:22:30 PDT
Created attachment 201701 [details]
Comment 2 Hyungchan Kim 2013-05-14 05:24:32 PDT
$ cat test_urls 
$ WebKitBuild/Release/bin/MiniBrowser -r test_urls 

WARNING: This project is using the experimental QML API extensions for QtWebKit and is therefore tied to a specific QtWebKit release.
WARNING: The experimental API will change from version to version, or even be removed. You have been warned!

QObject::connect: No such signal QQuickWebViewExperimentalExtension::loadStarted()
QObject::connect: No such signal QQuickWebViewExperimentalExtension::loadSucceeded()
QObject::connect: No such signal QQuickWebViewExperimentalExtension::loadFailed(QDesktopWebView::ErrorType, int, const QUrl&)
Loading http://www.google.com ......1
Number of leaked pixmaps: 9
Comment 3 Jocelyn Turcotte 2013-05-16 05:34:39 PDT
Comment on attachment 201701 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=201701&action=review

> Tools/MiniBrowser/qt/UrlLoader.cpp:49
> +    connect(this, SIGNAL(loadSucceeded()), this, SLOT(frameLoadFinished()));
> +    connect(this, SIGNAL(loadFailed()), this, SLOT(frameLoadFinished()));

loadSucceeded and loadFailed have the same effect, and UrlLoader is unlikely going to have external components using its API.
So no need to have two different signals, just use a loadFinished() signal that is triggered by LoadSucceededStatus, LoadFailedStatus and LoadStoppedStatus.

> Tools/MiniBrowser/qt/UrlLoader.cpp:141
> +

We don't usually put an empty line between the cases.
Comment 4 Hyungchan Kim 2013-05-16 06:50:57 PDT
Created attachment 201951 [details]
Comment 5 Jocelyn Turcotte 2013-05-16 07:02:23 PDT
Comment on attachment 201951 [details]

r=me, please set the "cq" flag to "?" on the attachment if you would like to use the commit queue to land the patch.
Comment 6 WebKit Commit Bot 2013-05-16 19:44:11 PDT
Comment on attachment 201951 [details]

Clearing flags on attachment: 201951

Committed r150229: <http://trac.webkit.org/changeset/150229>
Comment 7 WebKit Commit Bot 2013-05-16 19:44:13 PDT
All reviewed patches have been landed.  Closing bug.