Bug 116094

Summary: [Qt][Win] Input events aren't mapped properly with windowless plugins.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, jturcotte, net147
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jocelyn Turcotte 2013-05-14 01:56:41 PDT 
[Qt][Win] Input events aren't mapped properly with windowless plugins.
Comment 1 Jocelyn Turcotte 2013-05-14 02:00:06 PDT 
Created attachment 201689 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-14 02:01:38 PDT 
Attachment 201689 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/qt/QWebPageClient.h', u'Source/WebCore/plugins/win/PluginViewWin.cpp', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WidgetSupport/PageClientQt.cpp', u'Source/WebKit/qt/WidgetSupport/PageClientQt.h']" exit_code: 1
Source/WebCore/plugins/win/PluginViewWin.cpp:350:  Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]
Source/WebCore/plugins/win/PluginViewWin.cpp:362:  Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jocelyn Turcotte 2013-05-14 02:08:39 PDT 
(In reply to comment #2)
> Source/WebCore/plugins/win/PluginViewWin.cpp:350:  Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]

Source/WebCore/plugins subdirectories would need to be merged with those in Source/WebCore/platform. Hopefully we can land this patch first.
Comment 4 Tor Arne Vestbø 2013-05-27 05:10:48 PDT 
Comment on attachment 201689 [details]
Patch

lgtm
Comment 5 WebKit Commit Bot 2013-05-27 05:32:47 PDT 
Comment on attachment 201689 [details]
Patch

Clearing flags on attachment: 201689

Committed r150749: <http://trac.webkit.org/changeset/150749>
Comment 6 WebKit Commit Bot 2013-05-27 05:32:49 PDT 
All reviewed patches have been landed.  Closing bug.