Bug 11608

Summary:

[S60] render object of image type was wrongly typecast

Product:

WebKit

Reporter:

Shaun Keller <shaun.keller>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Normal

CC:

zalan

Priority:

Version:

412

Hardware:

S60 Emulator

OS:

S60 3rd edition

Attachments:

Description	Flags
render object of image type was wrongly typecast	zalan: review-
render object of image type was wrongly typecast and move brace so changelog script works	zalan: review+

Shaun Keller

Reported 2006-11-15 16:12:49 PST

TSW TMCN-6SWLXX

Attachments
render object of image type was wrongly typecast (1.53 KB, patch) 2006-11-15 16:21 PST, Shaun Keller	zalan: review-	Details Formatted Diff Diff
render object of image type was wrongly typecast and move brace so changelog script works (2.56 KB, patch) 2006-11-16 13:00 PST, Shaun Keller	zalan: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Shaun Keller

Comment 1 2006-11-15 16:21:08 PST

Created attachment 11535 [details] render object of image type was wrongly typecast

zalan

Comment 2 2006-11-16 08:24:00 PST

Comment on attachment 11535 [details] render object of image type was wrongly typecast i don't think that if( !type b ) cast to type a is a good pratcice. you could use const char *renderName() to find out the type of that object.

Shaun Keller

Comment 3 2006-11-16 13:00:31 PST

Created attachment 11543 [details] render object of image type was wrongly typecast and move brace so changelog script works Includes moving the brace to make the ChangeLog script work.

zalan

Comment 4 2006-11-16 13:13:06 PST

Comment on attachment 11543 [details] render object of image type was wrongly typecast and move brace so changelog script works r=me

Bradley Morrison

Comment 5 2006-11-17 08:17:42 PST

Some commments on this: - changelog entry does not reflect the patch - bug metadata is wrong. Please see the S60WebKit bugzilla documentation.

Bradley Morrison

Comment 6 2006-11-17 12:31:55 PST

> Some commments on this: > - changelog entry does not reflect the patch Apologies - I'm wrong. I read Zalan's comment and thought you reworded the CL entry for the 2nd patch based on his comments. My bad! > - bug metadata is wrong. Please see the S60WebKit bugzilla documentation. http://trac.webkit.org/projects/webkit/wiki/S60Buzilla - specifically 2nd last line.

zalan

Comment 7 2006-11-18 11:36:05 PST

r17843

Krishna

Comment 8 2006-12-11 10:33:05 PST

Closed.

Note You need to log in before you can comment on or make changes to this bug.