Summary: | Headers and footers should be pinned to the left edge of the window when scrolling horizontally | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||
Component: | Layout and Rendering | Assignee: | Beth Dakin <bdakin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, bdakin, cmarcelo, commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo, webkit-ews | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Beth Dakin
2013-05-13 14:26:00 PDT
Created attachment 201634 [details]
Patch
Comment on attachment 201634 [details] Patch Attachment 201634 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/468205 Comment on attachment 201634 [details] Patch Attachment 201634 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/427976 Comment on attachment 201634 [details] Patch Attachment 201634 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/346911 Comment on attachment 201634 [details] Patch Attachment 201634 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/464403 Created attachment 201636 [details]
Patch, attempting to fix builds
Comment on attachment 201636 [details] Patch, attempting to fix builds View in context: https://bugs.webkit.org/attachment.cgi?id=201636&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:2557 > m_layerForHeader->setPosition(FloatPoint(0, 0)); > + m_layerForHeader->setAnchorPoint(FloatPoint3D(0, 0, 0)); These could just be FloatPoint(), FloatPoint3D(). Thank you! http://trac.webkit.org/changeset/150043 |