Bug 116061

Summary: Headers and footers should be pinned to the left edge of the window when scrolling horizontally
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo, webkit-ews
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit-ews: commit-queue-
Patch, attempting to fix builds simon.fraser: review+

Beth Dakin
Reported 2013-05-13 14:26:00 PDT
Headers and footers should stay fixed on the horizontal axis, but they should scroll normally on the vertical axis. <rdar://problem/13599215>
Attachments
Patch (19.64 KB, patch)
2013-05-13 14:36 PDT, Beth Dakin 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch, attempting to fix builds (21.05 KB, patch)
2013-05-13 14:51 PDT, Beth Dakin 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2013-05-13 14:36:51 PDT
Created attachment 201634 [details] Patch
Early Warning System Bot
Comment 2 2013-05-13 14:42:24 PDT
Comment on attachment 201634 [details] Patch Attachment 201634 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/468205
EFL EWS Bot
Comment 3 2013-05-13 14:42:58 PDT
Comment on attachment 201634 [details] Patch Attachment 201634 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/427976
Early Warning System Bot
Comment 4 2013-05-13 14:43:06 PDT
Comment on attachment 201634 [details] Patch Attachment 201634 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/346911
EFL EWS Bot
Comment 5 2013-05-13 14:43:27 PDT
Comment on attachment 201634 [details] Patch Attachment 201634 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/464403
Beth Dakin
Comment 6 2013-05-13 14:51:37 PDT
Created attachment 201636 [details] Patch, attempting to fix builds
Simon Fraser (smfr)
Comment 7 2013-05-13 16:04:38 PDT
Comment on attachment 201636 [details] Patch, attempting to fix builds View in context: https://bugs.webkit.org/attachment.cgi?id=201636&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:2557 > m_layerForHeader->setPosition(FloatPoint(0, 0)); > + m_layerForHeader->setAnchorPoint(FloatPoint3D(0, 0, 0)); These could just be FloatPoint(), FloatPoint3D().
Beth Dakin
Comment 8 2013-05-13 16:15:39 PDT
Thank you! http://trac.webkit.org/changeset/150043
Note You need to log in before you can comment on or make changes to this bug.