Bug 11604

Summary: [S60] Remove RD_32_BROWSER flag from WebCore and WebKit
Product: WebKit Reporter: Pat <vincent.bradley>
Component: PlatformAssignee: Pat <vincent.bradley>
Status: CLOSED FIXED    
Severity: Critical Keywords: PlatformOnly
Priority: P2    
Version: 420+   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Attachments:
Description Flags
Remove obsolete flags from WebKit
Sachin.Padma: review-
S60Headers.zip file
none
Patch with S60Headers.zip file separate, see attachement of S60Headers.zip for the latest zip file. Sachin.Padma: review+

Description Pat 2006-11-15 12:29:28 PST
Remove the obsolete flag RD_32_BROWSER from the WebCore and WebKit code base.
Comment 1 Pat 2006-11-15 12:32:34 PST
Will create two patches. One for WebCore and one for WebKit for approval and inclusion into the tree.
Comment 2 Pat 2006-11-17 12:32:34 PST
Created attachment 11555 [details]
Remove obsolete flags from WebKit
Comment 3 Pat 2006-11-17 12:33:31 PST
Portions reviewed by the responsible engineers.
No changes in WebCore, the flags were not used there.
Two header files updated in the \S60\S60Internals\S60Headers.zip, HttpDownloadMgrCommon.h and BrowserUiInternalCRKeys.h.
The WebKit.loc and WebKit_sdk.loc, and WebKit.rss and WebKit_sdk.rss files changed to include each others new entries.

Comment 4 Sachin Padma 2006-11-20 15:00:16 PST
Comment on attachment 11555 [details]
Remove obsolete flags from WebKit

Can you please remove the S60headers from the patch. When I apply the patch it deletes this zip file.
Comment 5 Sachin Padma 2006-11-21 15:20:11 PST
This is not fixed yet.
Comment 6 Pat 2006-11-22 08:44:25 PST
Created attachment 11609 [details]
S60Headers.zip file

The zip files in S60Internal directory have to be added manually.
Comment 7 Pat 2006-11-22 08:48:32 PST
Created attachment 11610 [details]
Patch with S60Headers.zip file separate, see attachement of S60Headers.zip for the latest zip file.
Comment 8 Sachin Padma 2006-11-28 09:05:20 PST
Comment on attachment 11610 [details]
Patch with S60Headers.zip file separate, see attachement of S60Headers.zip for the latest zip file.

r=me
Comment 9 Sachin Padma 2006-11-28 09:33:33 PST
committed as r17905
Comment 10 Krishna 2006-12-05 10:57:26 PST
Verified and Closed.