Bug 116012

Summary: Move writeIndent, overloaded << operators from RenderTreeAsText to TextStream
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, commit-queue, dino, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, jamesr, kondapallykalyan, luiz, rego+ews, simon.fraser, tonikitoo, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117509    
Attachments:
Description Flags
Patch
webkit-ews: commit-queue-
Patch
none
Patch none

Zan Dobersek
Reported 2013-05-12 23:27:10 PDT
Move writeIndent, overloaded << operators from RenderTreeAsText to TextStream
Attachments
Patch (22.26 KB, patch)
2013-05-12 23:37 PDT, Zan Dobersek 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (22.35 KB, patch)
2013-05-13 05:01 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (22.93 KB, patch)
2013-10-28 14:08 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-05-12 23:37:00 PDT
Created attachment 201532 [details] Patch
Early Warning System Bot
Comment 2 2013-05-12 23:42:15 PDT
Comment on attachment 201532 [details] Patch Attachment 201532 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/427774
EFL EWS Bot
Comment 3 2013-05-12 23:42:17 PDT
Comment on attachment 201532 [details] Patch Attachment 201532 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/465200
Early Warning System Bot
Comment 4 2013-05-12 23:42:32 PDT
Comment on attachment 201532 [details] Patch Attachment 201532 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/465199
EFL EWS Bot
Comment 5 2013-05-12 23:43:00 PDT
Comment on attachment 201532 [details] Patch Attachment 201532 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/265752
kov's GTK+ EWS bot
Comment 6 2013-05-12 23:43:25 PDT
Comment on attachment 201532 [details] Patch Attachment 201532 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/466156
Zan Dobersek
Comment 7 2013-05-12 23:54:51 PDT
Comment on attachment 201532 [details] Patch Not yet ready it seems.
Zan Dobersek
Comment 8 2013-05-13 05:01:35 PDT
Created attachment 201547 [details] Patch
Zan Dobersek
Comment 9 2013-05-21 09:43:53 PDT
Hi Benjamin, could you perhaps take a look at this one?
Zan Dobersek
Comment 10 2013-06-11 10:30:49 PDT
The build target migration in the Autotools build system has been moved into bug #117509. Meanwhile, this patch is still up and ready for a review as it is.
Zan Dobersek
Comment 11 2013-10-28 14:08:43 PDT
Created attachment 215333 [details] Patch Rebased patch.
Zan Dobersek
Comment 12 2013-10-29 00:48:28 PDT
Comment on attachment 215333 [details] Patch Clearing flags on attachment: 215333 Committed r158183: <http://trac.webkit.org/changeset/158183>
Zan Dobersek
Comment 13 2013-10-29 00:48:36 PDT
All reviewed patches have been landed. Closing bug.
Zan Dobersek
Comment 14 2013-10-29 03:06:57 PDT
Build fixes for the debug Mac build landed in r158185 and r158187. This changed the output format of RemoteLayerTreeTextStream, but hopefully nothing breaks because of this. http://trac.webkit.org/changeset/158185 http://trac.webkit.org/changeset/158187
Note You need to log in before you can comment on or make changes to this bug.