|Product:||WebKit||Reporter:||Martin Robinson <mrobinson>|
|Component:||Tools / Tests||Assignee:||Patrick R. Gansterer <paroga>|
|Severity:||Normal||CC:||benjamin, cmarcelo, commit-queue, gyuyoung.kim, laszlo.gombos, paroga, rakuco|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Martin Robinson 2013-05-12 12:19:47 PDT
Files guarded by #ifdefs can be moved to the shared source list to avoid repetition and to simplify the build.
Comment 2 Patrick R. Gansterer 2013-05-15 02:19:58 PDT
Comment on attachment 201504 [details] Patch i don't like the idea of just compiling all files, since a) empty files also need time for compilation and b) you see many unused files when using an IDE (e.g. Visual Studio) maybe you can have a look at bug 116142 for my approach (at least for WTF) i'm ok with the ExecutableAllocatorFixedVMPool change, since it's only one single file
Comment 3 Gyuyoung Kim 2013-05-15 21:15:38 PDT
(In reply to comment #2) > (From update of attachment 201504 [details]) > i don't like the idea of just compiling all files, since a) empty files also need time for compilation and b) you see many unused files when using an IDE (e.g. Visual Studio) I prefer not to use #ifdef in CMake files. However, a bug was reported that build time was increased by unused files on window port. https://bugs.webkit.org/show_bug.cgi?id=115556#c9 So, +1 for Patrick's comment.
Comment 5 Gyuyoung Kim 2013-05-16 00:03:00 PDT
Comment on attachment 201930 [details] Patch LGTM. I believe Martin won't mind Patrick take this bug over ;)
Comment 6 WebKit Commit Bot 2013-05-16 17:14:30 PDT
Comment on attachment 201930 [details] Patch Clearing flags on attachment: 201930 Committed r150220: <http://trac.webkit.org/changeset/150220>
Comment 7 WebKit Commit Bot 2013-05-16 17:14:33 PDT
All reviewed patches have been landed. Closing bug.