| Summary: | Consolidate lists in JavaScriptCore CMake files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
| Component: | Tools / Tests | Assignee: | Patrick R. Gansterer <paroga> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue, gyuyoung.kim, laszlo.gombos, paroga, rakuco | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 116213 | ||||||||
| Attachments: |
|
||||||||
|
Description
Martin Robinson
2013-05-12 12:19:47 PDT
Created attachment 201504 [details]
Patch
Comment on attachment 201504 [details] Patch i don't like the idea of just compiling all files, since a) empty files also need time for compilation and b) you see many unused files when using an IDE (e.g. Visual Studio) maybe you can have a look at bug 116142 for my approach (at least for WTF) i'm ok with the ExecutableAllocatorFixedVMPool change, since it's only one single file (In reply to comment #2) > (From update of attachment 201504 [details]) > i don't like the idea of just compiling all files, since a) empty files also need time for compilation and b) you see many unused files when using an IDE (e.g. Visual Studio) I prefer not to use #ifdef in CMake files. However, a bug was reported that build time was increased by unused files on window port. https://bugs.webkit.org/show_bug.cgi?id=115556#c9 So, +1 for Patrick's comment. Created attachment 201930 [details]
Patch
Comment on attachment 201930 [details]
Patch
LGTM. I believe Martin won't mind Patrick take this bug over ;)
Comment on attachment 201930 [details] Patch Clearing flags on attachment: 201930 Committed r150220: <http://trac.webkit.org/changeset/150220> All reviewed patches have been landed. Closing bug. |