Bug 115985

Summary: Move RemoteMemoryReader into FastMalloc.cpp
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch kling: review+, eflews.bot: commit-queue-

Description Anders Carlsson 2013-05-12 08:57:27 PDT 
Move RemoteMemoryReader into FastMalloc.cpp
Comment 1 Anders Carlsson 2013-05-12 09:00:07 PDT 
Created attachment 201489 [details]
Patch
Comment 2 Anders Carlsson 2013-05-12 09:08:45 PDT 
Created attachment 201490 [details]
Patch
Comment 3 WebKit Commit Bot 2013-05-12 09:09:25 PDT 
Attachment 201490 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1
Source/WTF/wtf/FastMalloc.cpp:1134:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 EFL EWS Bot 2013-05-12 09:12:12 PDT 
Comment on attachment 201490 [details]
Patch

Attachment 201490 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/407959
Comment 5 Anders Carlsson 2013-05-12 09:12:42 PDT 
Created attachment 201491 [details]
Patch
Comment 6 EFL EWS Bot 2013-05-12 09:16:20 PDT 
Comment on attachment 201491 [details]
Patch

Attachment 201491 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/460414
Comment 7 EFL EWS Bot 2013-05-12 09:18:48 PDT 
Comment on attachment 201491 [details]
Patch

Attachment 201491 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/407961
Comment 8 Anders Carlsson 2013-05-12 09:19:46 PDT 
Created attachment 201492 [details]
Patch
Comment 9 WebKit Commit Bot 2013-05-12 09:20:44 PDT 
Attachment 201492 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1
Source/WTF/wtf/FastMalloc.cpp:1137:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 EFL EWS Bot 2013-05-12 09:22:41 PDT 
Comment on attachment 201492 [details]
Patch

Attachment 201492 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/417785
Comment 11 EFL EWS Bot 2013-05-12 09:23:19 PDT 
Comment on attachment 201492 [details]
Patch

Attachment 201492 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/461436
Comment 12 Anders Carlsson 2013-05-12 09:24:57 PDT 
Created attachment 201493 [details]
Patch
Comment 13 WebKit Commit Bot 2013-05-12 09:27:20 PDT 
Attachment 201493 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1
Source/WTF/wtf/FastMalloc.cpp:1139:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 EFL EWS Bot 2013-05-12 09:28:51 PDT 
Comment on attachment 201493 [details]
Patch

Attachment 201493 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/460422
Comment 15 EFL EWS Bot 2013-05-12 09:29:59 PDT 
Comment on attachment 201493 [details]
Patch

Attachment 201493 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/404445
Comment 16 Anders Carlsson 2013-05-12 09:32:11 PDT 
Created attachment 201494 [details]
Patch
Comment 17 WebKit Commit Bot 2013-05-12 09:34:07 PDT 
Attachment 201494 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1
Source/WTF/wtf/FastMalloc.cpp:1139:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:1140:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 18 EFL EWS Bot 2013-05-12 09:35:02 PDT 
Comment on attachment 201494 [details]
Patch

Attachment 201494 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/395511
Comment 19 EFL EWS Bot 2013-05-12 09:35:54 PDT 
Comment on attachment 201494 [details]
Patch

Attachment 201494 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/427576
Comment 20 Andreas Kling 2013-05-12 09:42:06 PDT 
Comment on attachment 201494 [details]
Patch

r=me but please tweak the EFL build system file.
Comment 21 Anders Carlsson 2013-05-12 09:44:58 PDT 
Committed r149963: <http://trac.webkit.org/changeset/149963>