Bug 115985

Summary: Move RemoteMemoryReader into FastMalloc.cpp
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch kling: review+, eflews.bot: commit-queue-

Anders Carlsson
Reported 2013-05-12 08:57:27 PDT
Move RemoteMemoryReader into FastMalloc.cpp
Attachments
Patch (9.01 KB, patch)
2013-05-12 09:00 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (10.03 KB, patch)
2013-05-12 09:08 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (9.23 KB, patch)
2013-05-12 09:12 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (10.32 KB, patch)
2013-05-12 09:19 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (10.73 KB, patch)
2013-05-12 09:24 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (10.73 KB, patch)
2013-05-12 09:32 PDT, Anders Carlsson 		kling: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-05-12 09:00:07 PDT
Created attachment 201489 [details] Patch
Anders Carlsson
Comment 2 2013-05-12 09:08:45 PDT
Created attachment 201490 [details] Patch
WebKit Commit Bot
Comment 3 2013-05-12 09:09:25 PDT
Attachment 201490 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1 Source/WTF/wtf/FastMalloc.cpp:1134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 4 2013-05-12 09:12:12 PDT
Comment on attachment 201490 [details] Patch Attachment 201490 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/407959
Anders Carlsson
Comment 5 2013-05-12 09:12:42 PDT
Created attachment 201491 [details] Patch
EFL EWS Bot
Comment 6 2013-05-12 09:16:20 PDT
Comment on attachment 201491 [details] Patch Attachment 201491 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/460414
EFL EWS Bot
Comment 7 2013-05-12 09:18:48 PDT
Comment on attachment 201491 [details] Patch Attachment 201491 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/407961
Anders Carlsson
Comment 8 2013-05-12 09:19:46 PDT
Created attachment 201492 [details] Patch
WebKit Commit Bot
Comment 9 2013-05-12 09:20:44 PDT
Attachment 201492 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1 Source/WTF/wtf/FastMalloc.cpp:1137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 10 2013-05-12 09:22:41 PDT
Comment on attachment 201492 [details] Patch Attachment 201492 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/417785
EFL EWS Bot
Comment 11 2013-05-12 09:23:19 PDT
Comment on attachment 201492 [details] Patch Attachment 201492 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/461436
Anders Carlsson
Comment 12 2013-05-12 09:24:57 PDT
Created attachment 201493 [details] Patch
WebKit Commit Bot
Comment 13 2013-05-12 09:27:20 PDT
Attachment 201493 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1 Source/WTF/wtf/FastMalloc.cpp:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 14 2013-05-12 09:28:51 PDT
Comment on attachment 201493 [details] Patch Attachment 201493 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/460422
EFL EWS Bot
Comment 15 2013-05-12 09:29:59 PDT
Comment on attachment 201493 [details] Patch Attachment 201493 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/404445
Anders Carlsson
Comment 16 2013-05-12 09:32:11 PDT
Created attachment 201494 [details] Patch
WebKit Commit Bot
Comment 17 2013-05-12 09:34:07 PDT
Attachment 201494 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1 Source/WTF/wtf/FastMalloc.cpp:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 18 2013-05-12 09:35:02 PDT
Comment on attachment 201494 [details] Patch Attachment 201494 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/395511
EFL EWS Bot
Comment 19 2013-05-12 09:35:54 PDT
Comment on attachment 201494 [details] Patch Attachment 201494 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/427576
Andreas Kling
Comment 20 2013-05-12 09:42:06 PDT
Comment on attachment 201494 [details] Patch r=me but please tweak the EFL build system file.
Anders Carlsson
Comment 21 2013-05-12 09:44:58 PDT
Committed r149963: <http://trac.webkit.org/changeset/149963>
Note You need to log in before you can comment on or make changes to this bug.