Web Inspector: AX: Console log of the Inspector does not announce output for screen readers

• Component: Web Inspector
• Status: RESOLVED FIXED

[Victor Tsaran]

Currently, after typing the expressions into the "console" edit area, the results are not being read back to the screen reader user.
One approach could be to use aria-live or role=status on the most important parts of the pane. The screen reader will then read the dynamic updates automatically.
This, however, needs to be tested and refined further.

[Radar WebKit Bug Importer]

<rdar://problem/13899156>

[James Craig]

Created attachment 205535 [details]
patch

[Timothy Hatcher]

Comment on attachment 205535 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205535&action=review

> Source/WebInspectorUI/UserInterface/LogContentView.js:38
> +    this.messagesElement.setAttribute('role', 'log');

Should always use double quotes.

> Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js:49
> +        element.setAttribute('data-labelprefix', WebInspector.UIString("Output: "));

Should always use double quotes.

[James Craig]

Created attachment 205563 [details]
patch with review feedback

[WebKit Commit Bot]

Comment on attachment 205563 [details]
patch with review feedback

Rejecting attachment 205563 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 205563, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/ConsoleCommand.js
|===================================================================
|--- UserInterface/ConsoleCommand.js	(revision 152003)
|+++ UserInterface/ConsoleCommand.js	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/977513

[James Craig]

Created attachment 205630 [details]
patch with corrected paths

previous patch was generated from a sub-directory, so the paths were wrong

[WebKit Commit Bot]

Comment on attachment 205630 [details]
patch with corrected paths

Rejecting attachment 205630 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 205630, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
his was:
--------------------------
|Index: UserInterface/LogContentView.css
|===================================================================
|--- UserInterface/LogContentView.css	(revision 152121)
|+++ UserInterface/LogContentView.css	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/899331

[James Craig]

Created attachment 205632 [details]
patch with corrected paths (for real this time)

[James Craig]

Heh. This must be why there is a dedicated webkit-patch script. ;-)

[WebKit Commit Bot]

Comment on attachment 205632 [details]
patch with corrected paths (for real this time)

Clearing flags on attachment: 205632

Committed r152136: <http://trac.webkit.org/changeset/152136>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.