| Summary: | Fix AppleConnect issues for WiFi interfaces | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Cooper <scooper> | ||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, commit-queue, scooper | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Cooper
2013-05-10 13:44:43 PDT
Created attachment 201418 [details]
Patch
Attachment 201418 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb']" exit_code: 1
Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The webkit-patch script is buggy when you combine the -g and —open-bug options. It fails to create a patch that contains the WebKit bug number, even though the ChangeLog gets edited and includes it. Created attachment 201420 [details]
Patch
Comment on attachment 201420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201420&action=review > Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:9 > (allow mach-lookup > (global-name-regex #"^com\.apple\.ist\.ds\.appleconnect2\.service\.PluginProcess\[[0-9]+\]$")) Is this still needed? Comment on attachment 201420 [details] Patch Clearing flags on attachment: 201420 Committed r149913: <http://trac.webkit.org/changeset/149913> All reviewed patches have been landed. Closing bug. |