Bug 115932

Summary: Fix AppleConnect issues for WiFi interfaces
Product: WebKit Reporter: Simon Cooper <scooper>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, scooper
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Cooper
Reported 2013-05-10 13:44:43 PDT
Fix AppleConnect issues for WiFi interfaces
Attachments
Patch (2.36 KB, patch)
2013-05-10 13:45 PDT, Simon Cooper 		no flags
DetailsFormatted DiffDiff
Patch (2.42 KB, patch)
2013-05-10 13:54 PDT, Simon Cooper 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Cooper
Comment 1 2013-05-10 13:45:37 PDT
Created attachment 201418 [details] Patch
WebKit Commit Bot
Comment 2 2013-05-10 13:50:38 PDT
Attachment 201418 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Cooper
Comment 3 2013-05-10 13:53:29 PDT
The webkit-patch script is buggy when you combine the -g and —open-bug options. It fails to create a patch that contains the WebKit bug number, even though the ChangeLog gets edited and includes it.
Simon Cooper
Comment 4 2013-05-10 13:54:02 PDT
Created attachment 201420 [details] Patch
Alexey Proskuryakov
Comment 5 2013-05-10 16:15:29 PDT
Comment on attachment 201420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201420&action=review > Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:9 > (allow mach-lookup > (global-name-regex #"^com\.apple\.ist\.ds\.appleconnect2\.service\.PluginProcess\[[0-9]+\]$")) Is this still needed?
WebKit Commit Bot
Comment 6 2013-05-10 16:41:25 PDT
Comment on attachment 201420 [details] Patch Clearing flags on attachment: 201420 Committed r149913: <http://trac.webkit.org/changeset/149913>
WebKit Commit Bot
Comment 7 2013-05-10 16:41:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.