Bug 115921

Summary: [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gtk-ews, gustavo, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 115937    
Bug Blocks: 115936    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2013-05-10 11:10:51 PDT
[GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
Attachments
Patch (16.01 KB, patch)
2013-05-10 11:22 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-05-10 11:22:20 PDT
Created attachment 201365 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-05-10 14:17:05 PDT
Comment on attachment 201365 [details] Patch LGTM. An interesting problem, though: apparently after building with this patch, then removing it a clean build is required: http://webkit-queues.appspot.com/results/406652 I think we need to make libPlatform and libWebCore depend on the files list for both (like we do here http://trac.webkit.org/browser/trunk/Source/WebCore/GNUmakefile.am#L453)
Zan Dobersek
Comment 3 2013-05-10 14:31:46 PDT
(In reply to comment #2) > (From update of attachment 201365 [details]) > LGTM. An interesting problem, though: apparently after building with this patch, then removing it a clean build is required: http://webkit-queues.appspot.com/results/406652 > > I think we need to make libPlatform and libWebCore depend on the files list for both (like we do here http://trac.webkit.org/browser/trunk/Source/WebCore/GNUmakefile.am#L453) Yikes, lots of typos there (Webcore should be WebCore). There's already a dependency set up for libWebCore there, so I reckon only one for libPlatform is missing?
kov's GTK+ EWS bot
Comment 4 2013-05-10 14:51:31 PDT
Comment on attachment 201365 [details] Patch Attachment 201365 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/405115
Gustavo Noronha (kov)
Comment 5 2013-05-13 09:53:01 PDT
Yep, but I think libWebCore should also depend on Platform's file list, because things are getting moved from one to the other. Otherwise libWebCore won't be relinked and we'll get duplicate symbols.
Zan Dobersek
Comment 6 2013-05-13 13:13:56 PDT
There's no Source/Platform/GNUmakefile.list.am yet, if that's the file you had in mind.
Gustavo Noronha (kov)
Comment 7 2013-05-14 07:05:29 PDT
Yep! I see the list is kept in the WebCore list for now, that should be enough then =)
Zan Dobersek
Comment 8 2013-05-14 10:40:14 PDT
Comment on attachment 201365 [details] Patch Clearing flags on attachment: 201365 Committed r150074: <http://trac.webkit.org/changeset/150074>
Zan Dobersek
Comment 9 2013-05-14 10:40:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.