| Summary: | [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, gtk-ews, gustavo, mrobinson, xan.lopez | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 115937 | ||||||
| Bug Blocks: | 115936 | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2013-05-10 11:10:51 PDT
Created attachment 201365 [details]
Patch
Comment on attachment 201365 [details] Patch LGTM. An interesting problem, though: apparently after building with this patch, then removing it a clean build is required: http://webkit-queues.appspot.com/results/406652 I think we need to make libPlatform and libWebCore depend on the files list for both (like we do here http://trac.webkit.org/browser/trunk/Source/WebCore/GNUmakefile.am#L453) (In reply to comment #2) > (From update of attachment 201365 [details]) > LGTM. An interesting problem, though: apparently after building with this patch, then removing it a clean build is required: http://webkit-queues.appspot.com/results/406652 > > I think we need to make libPlatform and libWebCore depend on the files list for both (like we do here http://trac.webkit.org/browser/trunk/Source/WebCore/GNUmakefile.am#L453) Yikes, lots of typos there (Webcore should be WebCore). There's already a dependency set up for libWebCore there, so I reckon only one for libPlatform is missing? Comment on attachment 201365 [details] Patch Attachment 201365 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/405115 Yep, but I think libWebCore should also depend on Platform's file list, because things are getting moved from one to the other. Otherwise libWebCore won't be relinked and we'll get duplicate symbols. There's no Source/Platform/GNUmakefile.list.am yet, if that's the file you had in mind. Yep! I see the list is kept in the WebCore list for now, that should be enough then =) Comment on attachment 201365 [details] Patch Clearing flags on attachment: 201365 Committed r150074: <http://trac.webkit.org/changeset/150074> All reviewed patches have been landed. Closing bug. |