Bug 115894

Summary: Remove [NoInterfaceObject] from several WebAudio IDL interfaces
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: arv, benjamin, buildbot, commit-queue, crogers, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, haraken, jer.noble, laszlo.gombos, rakuco, rniwa
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html
Attachments:
Description Flags
WIP Patch
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
none
Patch none

Description Chris Dumez 2013-05-10 02:16:20 PDT
A lot of WebAudio IDL interfaces have the [NoInterfaceObject] extended attribute, meaning that there is no corresponding attribute on the global window object. This is not according to specification [1] and should probably be fixed.

[1] https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html
Comment 1 Chris Dumez 2013-05-10 02:18:57 PDT
Created attachment 201326 [details]
WIP Patch
Comment 2 Chris Rogers 2013-05-10 11:56:05 PDT
Kentaro, I assume you will review this one?
Comment 3 Build Bot 2013-05-10 13:40:35 PDT
Comment on attachment 201326 [details]
WIP Patch

Attachment 201326 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/448136

New failing tests:
fast/js/global-constructors-attributes.html
Comment 4 Build Bot 2013-05-10 13:40:38 PDT
Created attachment 201417 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 5 Chris Dumez 2013-05-10 17:17:11 PDT
Created attachment 201443 [details]
Patch
Comment 6 WebKit Commit Bot 2013-05-10 18:24:10 PDT
Comment on attachment 201443 [details]
Patch

Clearing flags on attachment: 201443

Committed r149920: <http://trac.webkit.org/changeset/149920>
Comment 7 WebKit Commit Bot 2013-05-10 18:24:15 PDT
All reviewed patches have been landed.  Closing bug.