Bug 115854

Summary: [GTK] Module Cairo fails to build under jhbuild
Product: WebKit Reporter: Brian Holt <brian.holt>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gtk-ews, gustavo, mrobinson, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brian Holt 2013-05-09 03:38:39 PDT 
The Cairo library depends on glib and fails to build because the dependent library (glib) is not yet built.  It may build on some systems that have a newer version of glib by defaulting to the system installation.
Comment 1 Brian Holt 2013-05-09 03:45:30 PDT 
This is the error before the patch:

  CC     libcairo_gobject_la-cairo-gobject-structs.lo
In file included from /usr/include/glib-2.0/glib/galloca.h:34:0,
                 from /usr/include/glib-2.0/glib.h:32,
                 from /usr/include/glib-2.0/gobject/gbinding.h:30,
                 from /usr/include/glib-2.0/glib-object.h:25,
                 from cairo-gobject.h:44,
                 from cairo-gobject-structs.c:41:
/usr/include/glib-2.0/glib/gtypes.h:34:24: fatal error: glibconfig.h: No such file or directory
Comment 2 Brian Holt 2013-05-09 03:49:45 PDT 
Created attachment 201178 [details]
Patch
Comment 3 kov's GTK+ EWS bot 2013-05-09 04:44:19 PDT 
Comment on attachment 201178 [details]
Patch

Attachment 201178 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/398134
Comment 4 Martin Robinson 2013-05-09 07:48:53 PDT 
Comment on attachment 201178 [details]
Patch

Looks good, but please check out the EWS failure.
Comment 5 Brian Holt 2013-05-10 01:24:26 PDT 
The EWS failure was due to derived sources not building, but since fixed by zdobersek:

GEN: DerivedSources/WebCore/InternalSettingsGenerated.cpp
make: *** No rule to make target 'DerivedSources/WebCore/JSMallocStatistics.h' needed by 'DerivedSources/WebCore/JSMallocStatistics.cpp'. Stop.


Author: zandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu May 9 14:26:28 2013 +0000

    Unreviewed GTK build fix after r149796.
    
    * GNUmakefile.am: Add a phony target for the window constructors file and include it among
    the dependencies for the non-generated code.
Comment 6 Zan Dobersek 2013-05-10 07:16:22 PDT 
Affirmative, plus the gtk-wk2 EWS reported no issues.
I can cq+ the patch once the current build failure gets fixed.
Comment 7 WebKit Commit Bot 2013-05-10 10:03:51 PDT 
Comment on attachment 201178 [details]
Patch

Clearing flags on attachment: 201178

Committed r149883: <http://trac.webkit.org/changeset/149883>
Comment 8 WebKit Commit Bot 2013-05-10 10:03:54 PDT 
All reviewed patches have been landed.  Closing bug.