Bug 115854 – [GTK] Module Cairo fails to build under jhbuild

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Brian Holt]

The Cairo library depends on glib and fails to build because the dependent library (glib) is not yet built.  It may build on some systems that have a newer version of glib by defaulting to the system installation.

[Brian Holt]

This is the error before the patch:

  CC     libcairo_gobject_la-cairo-gobject-structs.lo
In file included from /usr/include/glib-2.0/glib/galloca.h:34:0,
                 from /usr/include/glib-2.0/glib.h:32,
                 from /usr/include/glib-2.0/gobject/gbinding.h:30,
                 from /usr/include/glib-2.0/glib-object.h:25,
                 from cairo-gobject.h:44,
                 from cairo-gobject-structs.c:41:
/usr/include/glib-2.0/glib/gtypes.h:34:24: fatal error: glibconfig.h: No such file or directory

[Brian Holt]

Created attachment 201178 [details]
Patch

[kov's GTK+ EWS bot]

Comment on attachment 201178 [details]
Patch

Attachment 201178 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/398134

[Martin Robinson]

Comment on attachment 201178 [details]
Patch

Looks good, but please check out the EWS failure.

[Brian Holt]

The EWS failure was due to derived sources not building, but since fixed by zdobersek:

GEN: DerivedSources/WebCore/InternalSettingsGenerated.cpp
make: *** No rule to make target 'DerivedSources/WebCore/JSMallocStatistics.h' needed by 'DerivedSources/WebCore/JSMallocStatistics.cpp'. Stop.


Author: [e-mail] <[e-mail]@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Thu May 9 14:26:28 2013 +0000

    Unreviewed GTK build fix after r149796.
    
    * GNUmakefile.am: Add a phony target for the window constructors file and include it among
    the dependencies for the non-generated code.

[Zan Dobersek]

Affirmative, plus the gtk-wk2 EWS reported no issues.
I can cq+ the patch once the current build failure gets fixed.

[WebKit Commit Bot]

Comment on attachment 201178 [details]
Patch

Clearing flags on attachment: 201178

Committed r149883: <http://trac.webkit.org/changeset/149883>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.