Bug 115832

Summary: Web Inspector: Make dragging off a tab in Safari with a docked Inspector work
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Timothy Hatcher 2013-05-08 16:54:26 PDT 
We need to reattach the Inspector when the window of the attached inspector and the inspected view don't match.
Comment 1 Timothy Hatcher 2013-05-08 16:54:50 PDT 
<rdar://problem/13605661>
Comment 2 Timothy Hatcher 2013-05-08 16:56:52 PDT 
Created attachment 201116 [details]
Patch
Comment 3 Joseph Pecoraro 2013-05-08 17:01:29 PDT 
Comment on attachment 201116 [details]
Patch

Looks good to me. A WK2 Owner probably needs to make final approval.
Comment 4 Timothy Hatcher 2013-05-08 17:12:42 PDT 
The better fix would be to have WKView notify the Inspector code when it moves windows or superviews so the attached Inspector can follow. I'll file that as a follow up since it would be more involved.
Comment 5 Timothy Hatcher 2013-05-08 17:15:51 PDT 
Filed that as bug 115833.
Comment 6 Benjamin Poulain 2013-05-09 01:56:45 PDT 
Comment on attachment 201116 [details]
Patch

Joe approved this. I think it is okay as a stopgap and a bug to fix this properly has been filed.
Comment 7 WebKit Commit Bot 2013-05-09 07:02:32 PDT 
Comment on attachment 201116 [details]
Patch

Clearing flags on attachment: 201116

Committed r149804: <http://trac.webkit.org/changeset/149804>
Comment 8 WebKit Commit Bot 2013-05-09 07:02:35 PDT 
All reviewed patches have been landed.  Closing bug.