Coalesce WKView visibleRect changes

• Component: WebKit2
• Status: RESOLVED FIXED

[Tim Horton]

AppKit can fiddle with the visibleRect a *lot* and call renewGState a *lot* during autolayout. We need to wait until it's settled down to inform the WebProcess of the new visibleRect, especially because in some particular cases, waiting until autolayout is done means the visibleRect doesn't change *at all*, and we can skip tons and tons of work that we would previously have done.

<rdar://problem/13776842>

[Tim Horton]

Created attachment 201091 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 201091 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201091&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:637
> +    if (m_sendViewExposedRectChangedTimer.isActive())
> +        m_sendViewExposedRectChangedTimer.stop();

Can't you unconditionally call stop?

> Source/WebKit2/UIProcess/WebPageProxy.h:1272
> +    WebCore::Timer<WebPageProxy> m_sendViewExposedRectChangedTimer;

Hard to parse this name. How about m_exposedRectChangedTimer?

> Source/WebKit2/UIProcess/WebPageProxy.h:1274
> +    WebCore::FloatRect m_lastSentViewExposedRect;

m_lastExposedRect?

[Tim Horton]

http://trac.webkit.org/changeset/149761