Bug 115792

Summary: Coalesce WKView visibleRect changes
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2013-05-08 03:34:11 PDT
AppKit can fiddle with the visibleRect a *lot* and call renewGState a *lot* during autolayout. We need to wait until it's settled down to inform the WebProcess of the new visibleRect, especially because in some particular cases, waiting until autolayout is done means the visibleRect doesn't change *at all*, and we can skip tons and tons of work that we would previously have done. <rdar://problem/13776842>
Attachments
patch (5.18 KB, patch)
2013-05-08 12:10 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-05-08 12:10:18 PDT
Created attachment 201091 [details] patch
Simon Fraser (smfr)
Comment 2 2013-05-08 12:15:13 PDT
Comment on attachment 201091 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=201091&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:637 > + if (m_sendViewExposedRectChangedTimer.isActive()) > + m_sendViewExposedRectChangedTimer.stop(); Can't you unconditionally call stop? > Source/WebKit2/UIProcess/WebPageProxy.h:1272 > + WebCore::Timer<WebPageProxy> m_sendViewExposedRectChangedTimer; Hard to parse this name. How about m_exposedRectChangedTimer? > Source/WebKit2/UIProcess/WebPageProxy.h:1274 > + WebCore::FloatRect m_lastSentViewExposedRect; m_lastExposedRect?
Tim Horton
Comment 3 2013-05-08 13:02:10 PDT
http://trac.webkit.org/changeset/149761
Note You need to log in before you can comment on or make changes to this bug.