Bug 115791

Summary: [EFL] Unreviewed EFL gardening
Product: WebKit Reporter: Riju <rijubrata>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, naginenis, rakuco, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Riju
Reported 2013-05-08 03:24:43 PDT
skipping some fast/regions/ test cases which failed after r149668 Some test cases need to be rebaselined.
Attachments
patch (3.53 KB, patch)
2013-05-08 03:39 PDT, Riju 		no flags
DetailsFormatted DiffDiff
patch (1.63 KB, patch)
2013-05-08 05:38 PDT, Riju 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Riju
Comment 1 2013-05-08 03:39:58 PDT
Created attachment 201052 [details] patch gardenining patch to rebaseline 1 test case. Skip a few fast/regions/ tests failing after (r149668).
Chris Dumez
Comment 2 2013-05-08 04:02:10 PDT
Comment on attachment 201052 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=201052&action=review > LayoutTests/ChangeLog:4 > + BUG id: webkit.org/b/115791 This does not seem like proper format for bug URL. Please use Tools/script/prepare-changelog -b BUGID to generate the changelog. > LayoutTests/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Please remove this line. > LayoutTests/ChangeLog:7 > + Missing changelog description. > LayoutTests/platform/efl/fast/dom/Range/getClientRects-expected.txt:228 > +FAIL rects[1].height should be 18. Was 17. Seems wrong to rebaseline if the test fails.
Riju
Comment 3 2013-05-08 05:38:07 PDT
Created attachment 201064 [details] patch
WebKit Commit Bot
Comment 4 2013-05-08 06:44:04 PDT
Comment on attachment 201064 [details] patch Clearing flags on attachment: 201064 Committed r149736: <http://trac.webkit.org/changeset/149736>
WebKit Commit Bot
Comment 5 2013-05-08 06:44:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.