Summary: | [CSS Exclusions] Simple shape-outside tests fail when subpixel layout is disabled | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hans Muller <giles_joplin> | ||||
Component: | CSS | Assignee: | Hans Muller <giles_joplin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 115292 | ||||||
Attachments: |
|
Description
Hans Muller
2013-05-07 15:48:28 PDT
Created attachment 201431 [details]
Patch
The overall goal of this change was to restore the (last) four excluded exclusions ref-tests by making them work correctly when subpixel layout is disabled. All of the tests were substantially simplified, as was the supporting javascript code. The original shape-outside-floats-simple-rounded-rectangle test was replaced by three separate tests because the original was bigger then then the 800x600 limit and because it unncessarily combined three indepedent test cases.
Note that the original description left out one of the ref-tests. The complete list is:
fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html
fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html
fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html
fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle.html
Comment on attachment 201431 [details]
Patch
A lot of changes. I partly trust that you did a good job here :/. r=me
Comment on attachment 201431 [details] Patch Clearing flags on attachment: 201431 Committed r150032: <http://trac.webkit.org/changeset/150032> All reviewed patches have been landed. Closing bug. |